Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neotest should respect when icons_enabled is false #1207

Closed
4 tasks done
windowsrefund opened this issue Sep 11, 2024 · 7 comments · Fixed by #1200
Closed
4 tasks done

neotest should respect when icons_enabled is false #1207

windowsrefund opened this issue Sep 11, 2024 · 7 comments · Fixed by #1200
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@windowsrefund
Copy link
Contributor

Checklist

  • I have searched through the AstroNvim documentation
  • I have searched through the existing issues of this project
  • I have searched the existing issues of plugins related to this issue
  • I can replicate the bug with the minimal repro.lua provided below

Neovim version (nvim -v)

doesn't matter

Operating system/version

does not matter

Terminal/GUI

does not matter

Describe the bug

neotest forces icons but the user may have chosen to disable them

Steps to Reproduce

use the community pack

Expected behavior

pack should respect the higher level icon_enabled boolean linked above.

Screenshots

No response

Additional Context

No response

Minimal configuration

-- not required
@windowsrefund windowsrefund added the bug Something isn't working label Sep 11, 2024
@Uzaaft
Copy link
Member

Uzaaft commented Sep 12, 2024

Minimal configuration is required. Please fill it in @windowsrefund

@Uzaaft Uzaaft added the incomplete Issue is missing information label Sep 12, 2024
@windowsrefund
Copy link
Contributor Author

There's no need as it wouldn't contribute to the perfectly described issue.

@Uzaaft
Copy link
Member

Uzaaft commented Sep 12, 2024

We require a minimal configuration. You'll have to fill it in.

@Uzaaft
Copy link
Member

Uzaaft commented Sep 12, 2024

We're literally asking you to do the bare minimum.

@windowsrefund
Copy link
Contributor Author

and I am LITERALLY (I know you kids love to use this word to overly sensationalize your communications) telling you the information provided is enough to act on. TBH, I don't care if this gets fixed or not. Feel free to close it.

@windowsrefund

This comment was marked as off-topic.

@luxus
Copy link
Member

luxus commented Sep 12, 2024

opts = function(_, opts)
if vim.g.icons_enabled == false then opts.style = "ascii" end
end,

a check like this could fix the issue

@luxus luxus added good first issue Good for newcomers and removed incomplete Issue is missing information labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants