Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Add lazydocker.nvim #1176

Merged
merged 5 commits into from
Aug 25, 2024

Conversation

Mourishitz
Copy link
Contributor

📑 Description

Adds Lazy Docker package to the AstroNvim community.

ℹ Additional Information

This PR adds a new shortcut to Leader + t + d which runs the Lazy Docker plugin.
It depends only on lazydocker.nvim and it uses built-in ToggleTerm support.

No breaking changes or old behavior interference.

image

Copy link

github-actions bot commented Aug 22, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@Mourishitz
Copy link
Contributor Author

Got it!! Tested it out and still runs smooth and perfect! Thanks for the suggestion

fixs(lazydocker): Fix opts table
@Uzaaft
Copy link
Member

Uzaaft commented Aug 24, 2024

You still didnt use it correctly. Test out the new plugin spec @Mourishitz

@Mourishitz
Copy link
Contributor Author

Yes it seems to work really well! Thanks for the suggestions, its my first contribution to astro community and I'm not used to the best practices yet

@Uzaaft Uzaaft merged commit b2d1e01 into AstroNvim:main Aug 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants