Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codesnap-nvim): Add default saving path #1121

Merged
merged 4 commits into from
Jul 28, 2024

Conversation

Std-Enigma
Copy link
Contributor

@Std-Enigma Std-Enigma commented Jul 23, 2024

Closes #1120

Copy link

github-actions bot commented Jul 23, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft
Copy link
Member

Uzaaft commented Jul 23, 2024

Hold off on merging this, I’m gonna try and upstream something instead

@Uzaaft
Copy link
Member

Uzaaft commented Jul 24, 2024

mistricky/codesnap.nvim#124 This will make this redundant

@Std-Enigma Std-Enigma closed this Jul 25, 2024
@Uzaaft Uzaaft reopened this Jul 28, 2024
@Uzaaft
Copy link
Member

Uzaaft commented Jul 28, 2024

Re-opened since the maintainer is slow to merge, which is fair enough. Let's get this merged and then we'll revert the changes whenever the upstream PR is merged.

@Uzaaft Uzaaft changed the title fix(codesnap-nvim): saving feature fix(codesnap-nvim): Add default saving path Jul 28, 2024
@Uzaaft Uzaaft merged commit 8661208 into AstroNvim:main Jul 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[codesnap-nvim] doesn't save the pictures to the drive
3 participants