Remove opinionated rust-analyzer config from astrocommunity.pack.rust

[boraarslan]

Is your feature related to a problem?

astrocommunity/lua/astrocommunity/pack/rust/init.lua

Lines 19 to 47 in b882cbb

	config = {
	rust_analyzer = {
	settings = {
	["rust-analyzer"] = {
	check = {
	command = "clippy",
	extraArgs = {
	"--no-deps",
	},
	},
	assist = {
	importEnforceGranularity = true,
	importPrefix = "crate",
	},
	completion = {
	postfix = {
	enable = false,
	},
	},
	inlayHints = {
	lifetimeElisionHints = {
	enable = true,
	useParameterNames = true,
	},
	},
	},
	},
	},
	},

There are multiple problems with this config.

astrocommunity/lua/astrocommunity/pack/rust/init.lua

Lines 29 to 32 in b882cbb

	assist = {
	importEnforceGranularity = true,
	importPrefix = "crate",
	},

This is entirely wrong and useless. These options are not under "assist". The correct namespaces are rust-analyzer.imports.granularity.enforce and rust-analyzer.imports.granularity.group

astrocommunity/lua/astrocommunity/pack/rust/init.lua

Lines 38 to 43 in b882cbb

	inlayHints = {
	lifetimeElisionHints = {
	enable = true,
	useParameterNames = true,
	},
	},

This just makes the inlay hints way too verbose. Most of the time, the lifetime elision hints are not helpful at all and just add noise.

astrocommunity/lua/astrocommunity/pack/rust/init.lua

Lines 33 to 37 in b882cbb

	completion = {
	postfix = {
	enable = false,
	},
	},

This is just a bad default. I'm not sure why this is disabled.

astrocommunity/lua/astrocommunity/pack/rust/init.lua

Lines 23 to 28 in b882cbb

	check = {
	command = "clippy",
	extraArgs = {
	"--no-deps",
	},
	},

This is controversial, to say the least. Using clippy as the check command causes very long feedback loops on larger projects as it's slower and heftier than cargo check.

Describe the new feature

The default rust-analyzer configuration is adequate for most people. This opinionated configuration should be removed as it doesn't offer any benefits over the default one.

Additional context

No response

[Uzaaft]

Feel free to open a PR @boraarslan

[Uzaaft]

Most of what you point out makes sense. But I find myself disagreeing with the clippy bit. The pack is there to provide a default for new users of astronvim, who might not know how to configure an LSP. It should stay IMO

[boraarslan]

@Uzaaft I'm not really opposed to defaulting to clippy; if I were to suggest something, I would've suggested that README should point out the default check command is not being cargo check and what the user should do in case they want to switch to the default behavior. IMO, doing the exact opposite (defaulting to cargo check and adding the steps needed to switch to cargo clippy to the README file) is better, but as I said, I don't have a strong stance on that.

[Uzaaft]

Let's document the cargo clippy behaviour, I think that makes sense.
Also, you're overestimating peoples ability to read the docs and make changes. 😂

[boraarslan]

Ahahahah, maybe you are right. I've updated the PR to include the documentation changes.

[Uzaaft]

Grazie Mille @boraarslan