Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(just): use native treesitter parser #1100

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ItsDrike
Copy link
Contributor

@ItsDrike ItsDrike commented Jul 9, 2024

📑 Description

The just pack was create a while ago, when nvim-treesitter didn't yet have support for the syntax. However, this support has now been added (and it's been there for quite a while), so there's no reason to add it manually.

Additionally, it turns out the build instructions here are actually wrong, as the repo doesn't contain the scanner.cc file anymore, so using the pack actually causes an error when attempting to install the parser. (How did no one notice this? lol):

Downloading tree-sitter-just...                                                                         
Creating temporary directory                                                                            
Extracting tree-sitter-just...                                                                          
Compiling...                                                                                            
cc1plus: fatal error: src/scanner.cc: No such file or directory                                         
compilation terminated.                                                                                 
                                                                                                        
Error during compilation                                                                                
Failed to execute the following command:                                                                
{                                                                                                       
  cmd = "cc",                                                                                           
  err = "Error during compilation",                                                                     
  info = "Compiling...",                                                                                
  opts = {                                                                                              
    args = { "-o", "parser.so", "-I./src", "src/parser.c", "src/scanner.cc", "-Os", "-shared", "-lstdc++
", "-fPIC" },                                                                                           
    cwd = "/home/itsdrike/.local/share/nvim/tree-sitter-just"                                           
  }                                                                                                     
} 
Press ENTER or type command to continue 

Copy link

github-actions bot commented Jul 9, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@mehalter mehalter changed the title Use native just treesitter parser fix(just): use native treesitter parser Jul 9, 2024
@mehalter
Copy link
Member

mehalter commented Jul 9, 2024

For future reference and future PRs. Make sure to read through the Contribution Guidelines so you know how to formulate the PR title and things.

@mehalter mehalter merged commit bd09782 into AstroNvim:main Jul 9, 2024
17 of 19 checks passed
@ItsDrike
Copy link
Contributor Author

ItsDrike commented Jul 9, 2024

For future reference and future PRs. Make sure to read through the Contribution Guidelines so you know how to formulate the PR title and things.

Oh, I was just doing that, but you merged it before i could ammend and fix the commit haha, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants