Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): better basedpyright defaults #1094

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix(python): better basedpyright defaults #1094

merged 2 commits into from
Jul 8, 2024

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Jul 8, 2024

No description provided.

Copy link

github-actions bot commented Jul 8, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@mehalter mehalter changed the title fix(python): Check for undefined table in before_init func fix(python): better basedpyright defaults Jul 8, 2024
@mehalter mehalter merged commit 0a5e7f6 into main Jul 8, 2024
15 checks passed
@mehalter mehalter deleted the fix/python branch July 8, 2024 11:42
@awerty-noob
Copy link

the default doesn't work on my astroNvim. When I open a python source code, a bunch of errors Type annotation is missing comes up, I checked Mason and the LSP server configuration schema shows that basedpyright.analysis.typeCheckingMode = "all"

@Uzaaft
Copy link
Member Author

Uzaaft commented Aug 11, 2024

the default doesn't work on my astroNvim. When I open a python source code, a bunch of errors Type annotation is missing comes up, I checked Mason and the LSP server configuration schema shows that basedpyright.analysis.typeCheckingMode = "all"

You can change the settings if you dont like the defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants