Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): set default go binary to "go" #1053

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

rami3l
Copy link
Contributor

@rami3l rami3l commented Jun 19, 2024

📑 Description

This prevents the error message that comes with the newer versions of go.nvim:

  if vim.fn.empty(_GO_NVIM_CFG.go) == 1 then
    vim.notify('go.nvim go binary is not setup', vim.log.levels.ERROR)
  end

https://github.com/ray-x/go.nvim/blob/b3ee7aea17d5b7acd1e3007efa7ac0e43947ad0c/lua/go.lua#L233-L235

ℹ Additional Information

I think the author could've given a good default to this value and make it overridable instead of issuing a hard error, but alas...

Tested with the following config override locally:

  { "ray-x/go.nvim", opts = { go = "go" } },

Copy link

github-actions bot commented Jun 19, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member

Uzaaft commented Jun 19, 2024

The fact that this is needed due to the hard error is just stupid...Thanks!

@Uzaaft Uzaaft merged commit 67268b2 into AstroNvim:main Jun 19, 2024
16 checks passed
@rami3l rami3l deleted the rami3l-patch-1 branch June 19, 2024 12:15
@rami3l rami3l restored the rami3l-patch-1 branch June 19, 2024 12:16
@rami3l rami3l deleted the rami3l-patch-1 branch June 19, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants