Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git): Add mini.git #1012

Merged
merged 3 commits into from
May 30, 2024
Merged

feat(git): Add mini.git #1012

merged 3 commits into from
May 30, 2024

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented May 30, 2024

No description provided.

@Uzaaft Uzaaft marked this pull request as ready for review May 30, 2024 13:02
Copy link

github-actions bot commented May 30, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft requested a review from a team May 30, 2024 13:02
@Uzaaft
Copy link
Member Author

Uzaaft commented May 30, 2024

I don't think opts is needed for this plugin.

@Uzaaft Uzaaft marked this pull request as draft May 30, 2024 13:05
@Uzaaft Uzaaft removed the request for review from a team May 30, 2024 13:05
@mehalter
Copy link
Member

it's not necessary but there are opts and a setup call, so might as well put it 🤷🏼

lua/astrocommunity/git/mini-git/init.lua Outdated Show resolved Hide resolved
lua/astrocommunity/git/mini-git/init.lua Show resolved Hide resolved
lua/astrocommunity/git/mini-git/init.lua Outdated Show resolved Hide resolved
lua/astrocommunity/git/mini-git/init.lua Show resolved Hide resolved
@Uzaaft Uzaaft requested a review from mehalter May 30, 2024 13:39
@Uzaaft Uzaaft marked this pull request as ready for review May 30, 2024 13:39
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mehalter mehalter merged commit b85974c into main May 30, 2024
13 checks passed
@mehalter mehalter deleted the feat/mini-git branch May 30, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants