Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update e2e-tests deps #1381

Merged
merged 6 commits into from
Nov 19, 2024
Merged

update e2e-tests deps #1381

merged 6 commits into from
Nov 19, 2024

Conversation

ermalkaleci
Copy link
Contributor

Pull Request Summary

Update e2e-tests dependencies

@ermalkaleci ermalkaleci marked this pull request as ready for review November 7, 2024 09:18
@ermalkaleci ermalkaleci added the tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc. label Nov 7, 2024
@ermalkaleci
Copy link
Contributor Author

/runtime-upgrade-test astar

Copy link

github-actions bot commented Nov 7, 2024

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/11720229666.
Please wait for a while.
Runtime: astar
Branch: feat/update-e2e-deps
SHA: 1a0e6ee

Dinonard
Dinonard previously approved these changes Nov 7, 2024
ipapandinas
ipapandinas previously approved these changes Nov 7, 2024
@ermalkaleci ermalkaleci dismissed stale reviews from ipapandinas and Dinonard via 9806588 November 7, 2024 09:48
@ermalkaleci
Copy link
Contributor Author

/runtime-upgrade-test astar

Copy link

github-actions bot commented Nov 7, 2024

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/11720515644.
Please wait for a while.
Runtime: astar
Branch: feat/update-e2e-deps
SHA: 9806588

@ermalkaleci
Copy link
Contributor Author

/runtime-upgrade-test astar

@ermalkaleci
Copy link
Contributor Author

@Dinonard @ipapandinas Can't test it here because it uses workfile from master branch. Please approve again

Copy link

github-actions bot commented Nov 7, 2024

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/unified-accounts/src 0% 0%
pallets/static-price-provider/src 85% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/vesting-mbm/src 89% 0%
precompiles/dapp-staking/src 90% 0%
precompiles/dapp-staking/src/test 0% 0%
precompiles/substrate-ecdsa/src 74% 0%
precompiles/assets-erc20/src 78% 0%
pallets/inflation/src 89% 0%
pallets/collective-proxy/src 86% 0%
primitives/src/xcm 65% 0%
pallets/price-aggregator/src 82% 0%
pallets/unified-accounts/src 86% 0%
pallets/collator-selection/src 92% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/ethereum-checked/src 74% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
pallets/dapp-staking/src/test 0% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
precompiles/sr25519/src 64% 0%
primitives/src 57% 0%
pallets/dapp-staking/src 83% 0%
precompiles/unified-accounts/src 100% 0%
pallets/xc-asset-config/src 50% 0%
chain-extensions/types/assets/src 0% 0%
precompiles/xcm/src 71% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dapp-staking/src/benchmarking 98% 0%
Summary 79% (3730 / 4738) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Contributor

@ipapandinas ipapandinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope but I've noticed that release-client.yml and release-runtime.yml still use setup-node@v2

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ermalkaleci can we merge this?

@ermalkaleci ermalkaleci merged commit f1631ab into master Nov 19, 2024
8 checks passed
@ermalkaleci ermalkaleci deleted the feat/update-e2e-deps branch November 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants