polkadot-sdk v1.11.0 uplift

[Dinonard]

Summary

Uplifts dependencies from polkadot-sdk-v1.9.0 to polkadot-v1.11.0.

• v1.10.0
• v1.11.0

Impact For Users

Deprecation of pallet-xcm calls

The following calls from pallet-xcm have been deprecated:

• reserve_transfer_assets - use limited_reserve_transfer_assets instead, with WeightLimit::Unlimited to keep the same behavior as before
• send - use send_blob instead
• execute - use execute_blob instead

Runtime API Update

XCM

Ability to check XCM payment fees, weight, fee amount.

Click here to check the API trait.

pub trait XcmPaymentApi<Call>
	where
		Call: Codec,
	{
		/// Returns a list of acceptable payment assets.
		///
		/// # Arguments
		///
		/// * `xcm_version`: Version.
		fn query_acceptable_payment_assets(xcm_version: Version) -> Result<Vec<VersionedAssetId>, Error>;
		/// Returns a weight needed to execute a XCM.
		///
		/// # Arguments
		///
		/// * `message`: `VersionedXcm`.
		fn query_xcm_weight(message: VersionedXcm<Call>) -> Result<Weight, Error>;
		/// Converts a weight into a fee for the specified `AssetId`.
		///
		/// # Arguments
		///
		/// * `weight`: convertible `Weight`.
		/// * `asset`: `VersionedAssetId`.
		fn query_weight_to_asset_fee(weight: Weight, asset: VersionedAssetId) -> Result<u128, Error>;
		/// Get delivery fees for sending a specific `message` to a `destination`.
		/// These always come in a specific asset, defined by the chain.
		///
		/// # Arguments
		/// * `message`: The message that'll be sent, necessary because most delivery fees are based on the
		///   size of the message.
		/// * `destination`: The destination to send the message to. Different destinations may use
		///   different senders that charge different fees.
		fn query_delivery_fees(destination: VersionedLocation, message: VersionedXcm<()>) -> Result<VersionedAssets, Error>;
	}

EVM Tracing

Alongside trace_call and trace_block, it is now also possible to trace a call directly, without the need for the transaction context.

        fn trace_call(
            header: &Block::Header,
            from: H160,
            to: H160,
            data: Vec<u8>,
            value: U256,
            gas_limit: U256,
            max_fee_per_gas: Option<U256>,
            max_priority_fee_per_gas: Option<U256>,
            nonce: Option<U256>,
            access_list: Option<Vec<(H160, Vec<H256>)>>,
        ) -> Result<(), sp_runtime::DispatchError>;

[Dinonard]

/bench astar-dev,shibuya-dev,shiden-dev all

[Dinonard]

/runtime-upgrade-test astar,shiden,shibuya

[github-actions]

Invalid runtime. It should be 'shibuya', 'shiden', or 'astar'.

[Dinonard]

/runtime-upgrade-test shibuya

[Dinonard]

/runtime-upgrade-test astar

[Dinonard]

/runtime-upgrade-test shiden

[Dinonard]

/bench astar-dev,shibuya-dev,shiden-dev all

[ipapandinas]

Also, I got the following error running tests locally:

ERROR xcm::weight: XcmFeeHandler::take_revenue failed when minting asset: Token(BelowMinimum)

@ipapandinas can can this be reproduced?

@Dinonard This comes from para_a_send_relay_asset_to_para_b test in fungible_assets.rs from xcm-simulator tests.
A fee of 40 for the new registered asset ID 123 is charged (so then minted) which is below the expected min ED for both paras: Some(123).
It was already there but it can be easily fixed. I suggest to adjust the min ED for both paras to Some(1) for example (as previous tests).

[github-actions]

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10299699208.
Please wait for a while.
Branch: feat/polkadot-sdk-v1.11.0-uplift
SHA: caae7ac

[ipapandinas]

LGTM! ✨

[github-actions]

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/10299699208.

[Dinonard]

@Dinonard This comes from para_a_send_relay_asset_to_para_b test in fungible_assets.rs from xcm-simulator tests.
A fee of 40 for the new registered asset ID 123 is charged (so then minted) which is below the expected min ED for both paras: Some(123).
It was already there but it can be easily fixed. I suggest to adjust the min ED for both paras to Some(1) for example (as previous tests).

Sorry but how to reproduce this again?

cargo test -p xcm-simulator-tests passes, everything is green.

[Dinonard]

/bench shibuya-dev,shiden-dev all

[ipapandinas]

Sorry but how to reproduce this again?

cargo test -p xcm-simulator-tests passes, everything is green.

@Dinonard Sorry I forgot to mention the command, I used:

cargo test -p xcm-simulator-tests --lib -- --exact --show-output

You may include RUST_LOG="xcm::weight=debug" but since its an error it should not be mandatory

[Dinonard]

@ipapandinas you meant the error in the log, now I see it.
It's fixed now.

[github-actions]

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10302935572.
Please wait for a while.
Branch: feat/polkadot-sdk-v1.11.0-uplift
SHA: 0cf39aa

[github-actions]

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/10302935572.

[github-actions]

Package	Line Rate	Branch Rate	Health
chain-extensions/pallet-assets/src	56%	0%	➖
precompiles/xcm/src	71%	0%	➖
primitives/src	59%	0%	➖
pallets/price-aggregator/src	82%	0%	✔
pallets/dapp-staking-migration/src	0%	0%	❌
pallets/unified-accounts/src	86%	0%	✔
pallets/dapp-staking-v3/src	86%	0%	✔
pallets/static-price-provider/src	85%	0%	✔
primitives/src/xcm	65%	0%	➖
pallets/inflation/src	93%	0%	✔
pallets/dapp-staking-v3/rpc/runtime-api/src	0%	0%	❌
precompiles/dapp-staking-v3/src	90%	0%	✔
precompiles/assets-erc20/src	78%	0%	➖
precompiles/sr25519/src	64%	0%	➖
pallets/dapp-staking-v3/src/benchmarking	98%	0%	✔
precompiles/dispatch-lockdrop/src	86%	0%	✔
chain-extensions/unified-accounts/src	0%	0%	❌
pallets/astar-xcm-benchmarks/src	86%	0%	✔
chain-extensions/types/assets/src	0%	0%	❌
pallets/ethereum-checked/src	74%	0%	➖
pallets/astar-xcm-benchmarks/src/generic	100%	0%	✔
pallets/collective-proxy/src	86%	0%	✔
precompiles/substrate-ecdsa/src	74%	0%	➖
precompiles/unified-accounts/src	100%	0%	✔
pallets/collator-selection/src	92%	0%	✔
pallets/dynamic-evm-base-fee/src	89%	0%	✔
pallets/xc-asset-config/src	50%	0%	➖
precompiles/dapp-staking-v3/src/test	0%	0%	❌
pallets/astar-xcm-benchmarks/src/fungible	100%	0%	✔
pallets/dapp-staking-v3/src/test	0%	0%	❌
chain-extensions/types/unified-accounts/src	0%	0%	❌
Summary	78% (3565 / 4591)	0% (0 / 0)	➖

Minimum allowed line rate is 50%

[ermalkaleci]

/bench shibuya-dev all

[github-actions]

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10309118965.
Please wait for a while.
Branch: feat/polkadot-sdk-v1.11.0-uplift
SHA: edde0ad

[github-actions]

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/10309118965.