-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local/Shibuya v1 governance integration #1260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean for me. Just commented on some nitpicks I found
@@ -1557,7 +1431,7 @@ pub mod pallet { | |||
#[pallet::weight(T::WeightInfo::force())] | |||
pub fn force(origin: OriginFor<T>, forcing_type: ForcingType) -> DispatchResult { | |||
Self::ensure_pallet_enabled()?; | |||
T::ManagerOrigin::ensure_origin(origin)?; | |||
ensure_root(origin)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we still have the possibility to dispatch root calls on live env ? Will Manager
still be relevant ?
Also please update the fn
description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, via democracy pallet.
And of course, sudo 🙂
/bench shibuya-dev pallet-collective-proxy |
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9760180110. |
Benchmarks have been finished. |
Minimum allowed line rate is |
Governance v1 Integration - Local & Shibuya
This PR integrates the governance v1 logic into
local
&shibuya
runtimes.New specialized pallet is added, as well as some modifications to the dApp staking logic.
dApp Staking
Collective Proxy
Primitives
Governance
Init Config
sudo
callCheck list