Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dApp staking v3 - pub(crate) visibility #1173

Closed
Dinonard opened this issue Feb 13, 2024 · 0 comments · Fixed by #1345
Closed

dApp staking v3 - pub(crate) visibility #1173

Dinonard opened this issue Feb 13, 2024 · 0 comments · Fixed by #1345
Labels
project Issue is part of an ongoing project

Comments

@Dinonard
Copy link
Member

Description

As an additional protection from misuse, structs used by dApp staking v3 & Tokenomics 2.0 pallets should make their fields as pub(crate) or private.

In case another pallet needs some data, it should be exposed via getters.
@Dinonard Dinonard added the project Issue is part of an ongoing project label Feb 13, 2024
@Dinonard Dinonard linked a pull request Aug 29, 2024 that will close this issue
dApp staking - crate visibility #1345
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project Issue is part of an ongoing project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dApp staking - crate visibility AstarNetwork/Astar
1 participant
@Dinonard