Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp Staking v3 & Tokenomics 2.0 - Shiden Integration #1161

Merged
merged 14 commits into from
Feb 6, 2024

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Feb 2, 2024

Pull Request Summary

Integrates dApp staking v3 & Tokenomics 2.0 into Shiden runtime.
Shiden parameters can be found here.

Also bumps up spec version & semver in preparation for v5.31.0 release.

Contains #1164.

Check list

  • pallets integrated
  • TODOs resolved
  • try-runtime testing
  • manual testing via chopsticks
  • revise on-runtime-upgrade logic
  • document testing procedure

@Dinonard Dinonard added shiden related to shiden runtime runtime This PR/Issue is related to the topic “runtime”. client This PR/Issue is related to the topic “client”. and removed client This PR/Issue is related to the topic “client”. labels Feb 2, 2024
@Dinonard
Copy link
Member Author

Dinonard commented Feb 2, 2024

/bench shiden-dev pallet_inflation,pallet_dapp_staking_v3

Copy link

github-actions bot commented Feb 2, 2024

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/7759627858.
Please wait for a while.
Branch: feat/shiden-ds-v3-t2-integration
SHA: a47794c

Copy link

github-actions bot commented Feb 2, 2024

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/7759627858.

@Dinonard
Copy link
Member Author

Dinonard commented Feb 4, 2024

/bench shiden-dev pallet_inflation,pallet_dapp_staking_v3

Copy link

github-actions bot commented Feb 4, 2024

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/7774788122.
Please wait for a while.
Branch: feat/shiden-ds-v3-t2-integration
SHA: 1a41408

@Dinonard
Copy link
Member Author

Dinonard commented Feb 4, 2024

/bench shiden-dev pallet_dapp_staking_migration

Copy link

github-actions bot commented Feb 4, 2024

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/7774788122.

Copy link

github-actions bot commented Feb 4, 2024

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/7775047211.
Please wait for a while.
Branch: feat/shiden-ds-v3-t2-integration
SHA: dbcebd7

Copy link

github-actions bot commented Feb 4, 2024

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/7775047211.

@Dinonard Dinonard marked this pull request as ready for review February 5, 2024 14:51
PierreOssun
PierreOssun previously approved these changes Feb 5, 2024
Copy link
Member

@PierreOssun PierreOssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that config match the one described in doc. Looks good

* Init commit

* Collator selection change

* Collator selection update

* Integration tests

* Update astar spec due to changes

* Weight updates
@Dinonard Dinonard added astar Related to Astar shibuya related to shibuya labels Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking-v3/src 88% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
chain-extensions/xvm/src 0% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dapps-staking/src 90% 0%
primitives/src/xcm 66% 0%
pallets/block-rewards-hybrid/src 91% 0%
pallets/dapp-staking-migration/src 49% 0%
pallets/xc-asset-config/src 64% 0%
precompiles/sr25519/src 64% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/collator-selection/src 89% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
precompiles/assets-erc20/src 81% 0%
chain-extensions/pallet-assets/src 56% 0%
precompiles/dapps-staking/src 94% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/dapps-staking/src/pallet 86% 0%
precompiles/xvm/src 74% 0%
primitives/src 59% 0%
pallets/inflation/src 80% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/unified-accounts/src 100% 0%
chain-extensions/types/assets/src 0% 0%
pallets/static-price-provider/src 58% 0%
pallets/unified-accounts/src 84% 0%
precompiles/xcm/src 72% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/ethereum-checked/src 75% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/xvm/src 51% 0%
pallets/astar-xcm-benchmarks/src 89% 0%
precompiles/substrate-ecdsa/src 74% 0%
Summary 79% (4389 / 5564) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard requested a review from PierreOssun February 6, 2024 13:29
@Dinonard Dinonard merged commit 83a4a81 into master Feb 6, 2024
11 checks passed
@Dinonard Dinonard deleted the feat/shiden-ds-v3-t2-integration branch February 6, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants