Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.29.0 prep #1139

Merged
merged 30 commits into from
Jan 17, 2024
Merged

Release v5.29.0 prep #1139

merged 30 commits into from
Jan 17, 2024

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Jan 17, 2024

Pull Request Summary

Release prep for v5.29.0 release.

  • spec & semver updates
  • removed dApps staking v2 & migration pallet from Shibuya
  • re-run benchmarks for dApps staking v3 due to many changes

Release issue: #1138

@Dinonard Dinonard added the shibuya related to shibuya label Jan 17, 2024
@Dinonard Dinonard added the runtime This PR/Issue is related to the topic “runtime”. label Jan 17, 2024
@Dinonard Dinonard changed the title Feat/release v5.29.0 prep Release v5.29.0 prep Jan 17, 2024
@Dinonard Dinonard marked this pull request as ready for review January 17, 2024 14:02
@Dinonard
Copy link
Member Author

/bench shibuya-dev pallet_dapp_staking_v3

Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/7557424797.
Please wait for a while.
Branch: feat/release-v5.29.0-prep
SHA: bc45639

Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/7557424797.

pub type Migrations = (
pallet_static_price_provider::InitActivePrice<Runtime, InitActivePriceGet>,
pallet_dapp_staking_v3::migrations::DappStakingV3TierRewardAsTree<Runtime>,
pallet_dapp_staking_v3::migrations::DappStakingV3HistoryCleanupMarkerReset<Runtime>,
pallet_inflation::PalletInflationShibuyaMigration<Runtime, NextEraProvider>,
frame_support::migrations::RemovePallet<
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    pallet_static_price_provider::InitActivePrice<Runtime, InitActivePriceGet>,
    pallet_dapp_staking_v3::migrations::DappStakingV3TierRewardAsTree<Runtime>,
    pallet_dapp_staking_v3::migrations::DappStakingV3HistoryCleanupMarkerReset<Runtime>,
    pallet_inflation::PalletInflationShibuyaMigration<Runtime, NextEraProvider>,

Those have not been applied yet right ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, these are all new.

I've removed the old ones the first time I had to add a new one.

Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/unified-accounts/src 84% 0%
pallets/block-rewards-hybrid/src 87% 0%
chain-extensions/types/assets/src 0% 0%
pallets/astar-xcm-benchmarks/src/fungible 0% 0%
pallets/astar-xcm-benchmarks/src/generic 0% 0%
primitives/src/xcm 66% 0%
pallets/dynamic-evm-base-fee/src 81% 0%
pallets/collator-selection/src 69% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
precompiles/unified-accounts/src 100% 0%
pallets/ethereum-checked/src 48% 0%
primitives/src 58% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/assets-erc20/src 81% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/static-price-provider/src 58% 0%
chain-extensions/xvm/src 0% 0%
precompiles/xvm/src 74% 0%
pallets/dapp-staking-v3/src/benchmarking 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/xc-asset-config/src 53% 0%
precompiles/sr25519/src 64% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/xvm/src 40% 0%
pallets/dapp-staking-migration/src 39% 0%
precompiles/xcm/src 72% 0%
precompiles/dapps-staking/src 94% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/dapp-staking-v3/src 76% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/dapps-staking/src 81% 0%
pallets/astar-xcm-benchmarks/src 0% 0%
pallets/dapps-staking/src/pallet 85% 0%
pallets/inflation/src 69% 0%
Summary 70% (3264 / 4690) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit d778f12 into master Jan 17, 2024
9 checks passed
@Dinonard Dinonard deleted the feat/release-v5.29.0-prep branch January 17, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants