Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UnsafeUnstableInterface in local-runtime #1118

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Dec 31, 2023

For some reason UnsafeUnstableInterface is disabled in local-runtime, even though it is enabled in Shibuya.

This is pretty confusing and it took me quite some time to notice when I was doing e2e contract testing after testing the functionality manually on Shibuya.

This PR fixes that so that others do not run into this same issue 😅

@ashutoshvarma ashutoshvarma added the runtime This PR/Issue is related to the topic “runtime”. label Jan 2, 2024
@Dinonard
Copy link
Member

Dinonard commented Jan 2, 2024

I guess this is debatable - do you want to mimic Shibuya environment or Astar environment?
Neither is wrong or right, I guess.

Someone could equally raise an issue later that a contract worked on local but doesn't work on Astar since unstable interface isn't enabled.

@Szegoo
Copy link
Contributor Author

Szegoo commented Jan 3, 2024

Yes, there isn't really a 'correct' way to configure this. However, considering that the local-runtime doesn't closely resemble the Astar runtime and is meant for local testing, I think it would make more sense to have this enabled.

@Dinonard
Copy link
Member

Dinonard commented Jan 5, 2024

Yes, there isn't really a 'correct' way to configure this. However, considering that the local-runtime doesn't closely resemble the Astar runtime and is meant for local testing, I think it would make more sense to have this enabled.

We can merge it, sure.
If issue is mentioned or raised again, we'll have to consider a different approach.

@Dinonard Dinonard merged commit 8fc8deb into AstarNetwork:master Jan 5, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants