Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XVM: replace MultiAddress with AccountId for ink! contracts #1021

Closed
shaunxw opened this issue Sep 5, 2023 · 0 comments · Fixed by #1024
Closed

XVM: replace MultiAddress with AccountId for ink! contracts #1021

shaunxw opened this issue Sep 5, 2023 · 0 comments · Fixed by #1024
Assignees
@shaunxw

Comments

@shaunxw
Copy link
Member

shaunxw commented Sep 5, 2023 •
edited
Loading

And update tests.

Context

As discussed offline with @PierreOssun , using MultiAddress type for ink! contract address is mainly because of dispatch-able calls in the previous pallet-xvm impl. And as we won't add dispatch-able calls to refreshed pallet-xvm design, there is no need the wrap the AccountId type ink! contract address in MultiAddress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaunxw shaunxw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

XVM: replace MultiAddress with AccountId for ink! contracts AstarNetwork/Astar
1 participant
@shaunxw