From f4fcec25380db062fe909d6fa135b84266d9f9d7 Mon Sep 17 00:00:00 2001 From: Deepanshu Hooda Date: Sat, 21 Oct 2023 01:40:18 +0530 Subject: [PATCH] comments edit --- pallets/astar-xcm-benchmarks/src/generic/benchmarking.rs | 2 +- runtime/shibuya/src/weights/xcm_instruction_benchmarks/mod.rs | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/pallets/astar-xcm-benchmarks/src/generic/benchmarking.rs b/pallets/astar-xcm-benchmarks/src/generic/benchmarking.rs index 0a56832391..4e1bbe71b9 100644 --- a/pallets/astar-xcm-benchmarks/src/generic/benchmarking.rs +++ b/pallets/astar-xcm-benchmarks/src/generic/benchmarking.rs @@ -107,7 +107,7 @@ benchmarks! { }: { executor.bench_process(xcm)?; } verify { - // TODO Make the assertion configurable? + // The assert above is enough to show this XCM succeeded } refund_surplus { diff --git a/runtime/shibuya/src/weights/xcm_instruction_benchmarks/mod.rs b/runtime/shibuya/src/weights/xcm_instruction_benchmarks/mod.rs index 7633bf4fb5..55fa4dab29 100644 --- a/runtime/shibuya/src/weights/xcm_instruction_benchmarks/mod.rs +++ b/runtime/shibuya/src/weights/xcm_instruction_benchmarks/mod.rs @@ -166,10 +166,6 @@ impl XcmWeightInfo for ShibuyaXcmWeight { _reserve: &MultiLocation, _xcm: &Xcm<()>, ) -> XCMWeight { - // TODO: Clear wrong - // This is not correct. initiate reserve withdraw does not to that many db reads - // the only thing it does based on number of assets is a take from a local variable - //assets.weigh_multi_assets(XcmGeneric::::initiate_reserve_withdraw()) XcmGeneric::::initiate_reserve_withdraw() } fn initiate_teleport(