Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] String compare broken on sub-strings #1582

Closed
thisisjoshford opened this issue Dec 14, 2020 · 1 comment · Fixed by #1583
Closed

[ BUG ] String compare broken on sub-strings #1582

thisisjoshford opened this issue Dec 14, 2020 · 1 comment · Fixed by #1583
Labels
bug

Comments

@thisisjoshford
Copy link

Here is an example of comparing the string "1" and "10", and it is never the case that is either less than, greater than, or equal to. I would expect "1" to be less than "10" :)
@MaxGraey
Copy link
Member

Good catch!

@MaxGraey MaxGraey added the bug label Dec 14, 2020
@MaxGraey MaxGraey mentioned this issue Dec 14, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix wrong string comparision when sizes are differ
2 participants
@MaxGraey @thisisjoshford