Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<enclosure> tag in the item is not used #769

Closed
ghost opened this issue Jun 18, 2024 · 1 comment · Fixed by #799
Closed

<enclosure> tag in the item is not used #769

ghost opened this issue Jun 18, 2024 · 1 comment · Fixed by #799
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ghost
Copy link

ghost commented Jun 18, 2024

All "enclosure" tags are not used from https://www.clubic.com/feed/news.rss :

For example :
<enclosure url="https://pic.clubic.com/v1/images/1882727/raw" type="image/jpeg" length="0"/>

After the fix :
#681

https://github.com/Ashinch/ReadYou/compare/746092103f2343f24e69669dbfa9e5d88ebe49d6..b98228bd0e03ce9e08b2d50cb577c8e62f76aec3

The regex works : https://regex101.com/r/FDuVwQ/1
Perhaps it's the attribut length=0 or the filename with no extension...

There are no picture with ReadYou v0.10.1.
The picture is show with Feeder.

@ghost ghost added the bug Something isn't working label Jun 18, 2024
@Ashinch Ashinch self-assigned this Jul 12, 2024
@Ashinch Ashinch added this to the 0.11.0 milestone Jul 12, 2024
@Ashinch
Copy link
Owner

Ashinch commented Jul 12, 2024

This is because the of the feed is in the rss attribute, and the previous processing ignored them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant