Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clothing shop not returning items when selecting NONE #570

Open
AngryHerring opened this issue Jul 18, 2019 · 8 comments
Open

Clothing shop not returning items when selecting NONE #570

AngryHerring opened this issue Jul 18, 2019 · 8 comments
Labels
needing-confirmation For issues that are awaiting verification that what they are reporting is a genuine problem.

Comments

@AngryHerring
Copy link

AngryHerring commented Jul 18, 2019

Expected behaviour

When selecting "REMOVE VEST" or "REMOVE BACKPACK", and closing the shop in a normal fashion, your vest and backpack should be returned.

Actual behaviour

The shop doesn't return VEST or BACKPACK

Steps to reproduce the behaviour

  1. Currently have an existing VEST or BACKPACK on you.
  2. Open clothing shop.
  3. Select "REMOVE _X" (Vest or backpack).
  4. Close the shop (Exit).
  5. Doesn't return back to previous vest OR backpack

[RPT]

Server .rtp: https://pastebin.com/hZnvewbt
Client .rtp: https://pastebin.com/0MKtcuLb


Mission version: 5.0

@klmunday
Copy link
Contributor

Hello thanks for the report
I have noticed you are using modified files, if possible could you please test this with fresh files to ensure this is not an error caused by modifications?
thanks

@AngryHerring
Copy link
Author

@klmunday Yes, I've indeed tested this with clean framework from github aswell. The same bug occurs. Please note that if you attempt it with headgear, clothing or glasses the script will return the items correctly!

@AngryHerring
Copy link
Author

Here is a video demonstrating this bug (clean framework):
https://youtu.be/1KyKYIcxuBU

@Jason2605 Jason2605 added the needing-confirmation For issues that are awaiting verification that what they are reporting is a genuine problem. label Aug 4, 2019
@blackfisch
Copy link
Contributor

Honestly, I have no problem with the option "Remove X" to actually remove the item. I (for my part) never really interpreted it as such, that the item is given back to you (hence the name "remove").
That doesn't mean I don't support maybe a second option to select "No Change" (or sth like that).

Remove X -> actually removed the item from your inventory
No Change -> gives you the old item back

@klmunday
Copy link
Contributor

Yes I would agree, if a person selects remove backpack and then proceeds to cancel it should give the old backpack back, good spot

@blackfisch
Copy link
Contributor

Yes I would agree, if a person selects remove backpack and then proceeds to cancel it should give the old backpack back, good spot

sorry, am i missing something? do you mean if you select remove and cancel the gear disappears? I'll check that :D

@klmunday
Copy link
Contributor

That's what was happening in the video. Or am I misinterpreting this issue?

@blackfisch
Copy link
Contributor

That's what was happening in the video. Or am I misinterpreting this issue?

ah, my bad. thought he clicked buy.... my bad tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needing-confirmation For issues that are awaiting verification that what they are reporting is a genuine problem.
Projects
None yet
Development

No branches or pull requests

4 participants