Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Extend album format support #150

Open
brendan-pike opened this issue Dec 1, 2021 · 3 comments
Open

Request: Extend album format support #150

brendan-pike opened this issue Dec 1, 2021 · 3 comments

Comments

@brendan-pike
Copy link
Contributor

I like the new album format displays. Can this be extended somehow to show more details, eg.
SACD, Vinyl, MP3 etc etc.
One album I have is 24bit - 176.4kHz but the file media is tagged as SHM-SACD (2 channels) but its only shown as 24/176.
This info would be welcome on the Album and Now Playing view also.

@marcbth
Copy link

marcbth commented Dec 1, 2021

Hello brendan-pike,

I have solved this as follows:

you only have to change the following 2 lines in the

/include/library.inc.php

at the very end

Function calculateAlbumFormat

line 3519

Return "CD";

after

return $album_information['audio_dataformat'] . ' ' . "CD";

and

line 3536

return $album_information['audio_bits_per_sample'] . '/' . round($album_information['audio_sample_rate']/1000,0);

return $album_information['audio_dataformat'] . ' .$album_information['audio_bits_per_sample'] . '/' . round($album_information['audio_sample_rate']/1000,0);

Cliff
Bildschirmfoto 2021-12-01 um 13 50 27

@marcbth
Copy link

marcbth commented Dec 2, 2021

sorry

return $album_information['audio_dataformat'] . ' ' .$album_information['audio_bits_per_sample'] . '/' . round($album_information['audio_sample_rate']/1000,0);

@brendan-pike
Copy link
Contributor Author

Thanks marcbth

I've modified as suggested, it's a nice addition. Its a pet theme of mine and I'm sure poor Artur gets tired of hearing about it :) but for me I like details. Relative to this item for example I would like to know the original source format not just the file format, for example a flac file may be 24/176 but this may of been a HD file download, a SACD rip, or even a Vinyl/LP rip into that 24/176 file which you can't tell unless you inspect the files 'media' tag.

For example I have an album News Of The World by Queen, which is 16bit 44.1 FLAC and in media I can see the original source was a "SHM-SACD (2 channels)" and I will at times have multiple copies of the same album from different sources.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants