Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More protection against INT32 datasets that (might) contain -2^31 values #8

Open
LTLA opened this issue Feb 21, 2024 · 0 comments
Open

Comments

@LTLA
Copy link
Member

LTLA commented Feb 21, 2024

For floating-point datasets, these should be coerced to the float; I don't think they are at the moment.

For integer datasets, we should just throw an error, because it's just impossible to preserve integer-ness. We can't even fall back to floating point like in alabaster.base because we need to stick by the type promises of extract_*_array()... so, just give up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant