Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

train dataset is shuffled regardless of seed #108

Open
goonbamm opened this issue Jul 14, 2023 · 0 comments
Open

train dataset is shuffled regardless of seed #108

goonbamm opened this issue Jul 14, 2023 · 0 comments

Comments

@goonbamm
Copy link

Thank you for your great code.

Actually, I found that the dataset sampler does not get any seed, so it use default value '0' as seed. It seems that the seed only affects the initialization of the model.

So I think we need add the following parameters for all samplers.

train_sampler = torch.utils.data.distributed.DistributedSampler(msvd_dataset)
# default: shuffle = True, seed = 0
train_sampler = torch.utils.data.distributed.DistributedSampler(msvd_dataset, shuffle=True, seed=args.seed)

I apologize in advance if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant