Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swerve, YAGSL] Configuration swerve subsystem #2

Merged
merged 11 commits into from
Aug 7, 2024
Merged

[Swerve, YAGSL] Configuration swerve subsystem #2

merged 11 commits into from
Aug 7, 2024

Conversation

Tricks1228
Copy link
Contributor

No description provided.

WispySparks
WispySparks requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@WispySparks WispySparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!
Keep in mind all PID values, inversions, and absolute encoder offsets will have to be tuned once we have the swerve drive.

src/main/deploy/swerve/modules/backleft.json Outdated Show resolved Hide resolved
src/main/deploy/swerve/modules/backleft.json Outdated Show resolved Hide resolved
src/main/deploy/swerve/modules/backleft.json Outdated Show resolved Hide resolved
src/main/deploy/swerve/modules/backleft.json Show resolved Hide resolved
src/main/deploy/swerve/modules/physicalproperties.json Show resolved Hide resolved
src/main/deploy/swerve/modules/pidfproperties.json Outdated Show resolved Hide resolved
src/main/java/frc/robot/Constants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Swerve.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Swerve.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Swerve.java Outdated Show resolved Hide resolved
@WispySparks WispySparks changed the title Configuration swerve subsystem [Swerve, YAGSL] Configuration swerve subsystem Jul 31, 2024
@WispySparks WispySparks merged commit a1e557b into main Aug 7, 2024
1 check passed
@WispySparks WispySparks deleted the configuration-swerve-subsystem branch August 7, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WispySparks WispySparks WispySparks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tricks1228 @WispySparks