Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: timeout NPM requests and continue execution #1923

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

got by default has no timeout which means requests are ongoing until the server terminates them. Also, any exceptions thrown during the plugin manager bootstrap weren't handled so the wallet would get stuck.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels May 15, 2020
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #1923 into develop will decrease coverage by 0.02%.
The diff coverage is 21.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1923      +/-   ##
===========================================
- Coverage    58.93%   58.91%   -0.03%     
===========================================
  Files          372      373       +1     
  Lines         9308     9313       +5     
  Branches      1932     1933       +1     
===========================================
+ Hits          5486     5487       +1     
- Misses        3595     3599       +4     
  Partials       227      227              
Impacted Files Coverage Δ
src/renderer/App.vue 22.97% <0.00%> (-0.64%) ⬇️
...er/services/plugin-manager/adapters/npm-adapter.js 8.69% <0.00%> (ø)
src/renderer/store/modules/network.js 31.25% <0.00%> (ø)
src/renderer/services/plugin-manager.js 49.14% <25.00%> (ø)
src/renderer/services/wallet.js 94.33% <100.00%> (ø)
src/renderer/utils/http.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420e1a4...17e2cf6. Read the comment docs.

@faustbrian faustbrian merged commit 7c77e12 into develop May 18, 2020
@ghost ghost deleted the npm-down branch May 18, 2020 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant