This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
feat: add scope to plugin routes and menu items #1833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Multiple plugins that define the same routes can currently result in unexpected routing. For example the following configuration will potentially route to the original ARK Explorer plugin (if installed and enabled):
This PR scopes the plugin routes under the plugin's id. Navigation through the
ROUTES
permission can still be done without using the scope.Checklist