Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add scope to plugin routes and menu items #1833

Merged
merged 2 commits into from
Mar 14, 2020
Merged

feat: add scope to plugin routes and menu items #1833

merged 2 commits into from
Mar 14, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Mar 13, 2020

Summary

Multiple plugins that define the same routes can currently result in unexpected routing. For example the following configuration will potentially route to the original ARK Explorer plugin (if installed and enabled):

    this.routes = [
      {
        path: '/my-ark-explorer,
        name: 'ark-explorer',
        component: 'MyExplorer
      }
    ]

    this.menuItems = [
      {
        routeName: 'ark-explorer',
        title: 'My ARK Explorer'
      }
    ]

This PR scopes the plugin routes under the plugin's id. Navigation through the ROUTES permission can still be done without using the scope.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Mar 13, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality. labels Mar 13, 2020
@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Mar 14, 2020
@faustbrian faustbrian merged commit 4811bca into ArkEcosystem:develop Mar 14, 2020
@ghost
Copy link

ghost commented Mar 14, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the feat/scoped-plugin-routes branch March 14, 2020 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants