Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: try to fetch local plugin images first #1826

Merged
merged 1 commit into from
Mar 14, 2020
Merged

refactor: try to fetch local plugin images first #1826

merged 1 commit into from
Mar 14, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Mar 12, 2020

Summary

Fixes: fetching of the preview images was nested in the catch black, therefore was never called when the service successfully read the logo file of a locally installed plugin.

Refactors: instead of fetching the preview images from the defined URLs directly, try to get the images from a default path first (images/).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Mar 12, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Mar 12, 2020
@ghost
Copy link

ghost commented Mar 13, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Mar 13, 2020
@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Mar 14, 2020
@ghost
Copy link

ghost commented Mar 14, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 0b4d5ba into ArkEcosystem:develop Mar 14, 2020
@ghost
Copy link

ghost commented Mar 14, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the refactor/plugin-images-locally branch March 14, 2020 06:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants