This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
refactor: try to fetch local plugin images first #1826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: fetching of the preview images was nested in the catch black, therefore was never called when the service successfully read the logo file of a locally installed plugin.
Refactors: instead of fetching the preview images from the defined URLs directly, try to get the images from a default path first (
images/
).Checklist