Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: replace pricing api with @arkecosystem/platform-sdk #1786

Merged
merged 3 commits into from
Mar 9, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Mar 6, 2020

Replaces the pricing APIs with ones from https://github.com/ArkEcosystem/platform-sdk which will be used to share things across our applications. Also removes a bunch of methods that I couldn't find any reference of usage for.

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Mar 6, 2020
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@dc46646). Click here to learn what that means.
The diff coverage is 51.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1786   +/-   ##
==========================================
  Coverage           ?   59.42%           
==========================================
  Files              ?      363           
  Lines              ?     9025           
  Branches           ?     1831           
==========================================
  Hits               ?     5363           
  Misses             ?     3480           
  Partials           ?      182
Impacted Files Coverage Δ
...rc/renderer/components/MarketChart/MarketChart.vue 31.85% <0%> (ø)
src/renderer/store/modules/market.js 4.34% <0%> (ø)
src/renderer/components/Network/NetworkModal.vue 47.9% <100%> (ø)
src/renderer/services/price-api.ts 53.12% <53.12%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc46646...20a7d05. Read the comment docs.

@faustbrian faustbrian merged commit b8e7672 into develop Mar 9, 2020
@faustbrian faustbrian deleted the psdk-pricing branch March 9, 2020 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant