Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: change wording for contact delete button #1774

Merged
merged 3 commits into from
Mar 9, 2020

Conversation

alexbarnsley
Copy link
Member

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Mar 4, 2020
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #1774 into develop will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1774      +/-   ##
===========================================
- Coverage    59.89%   59.87%   -0.02%     
===========================================
  Files          366      366              
  Lines         9146     9150       +4     
  Branches      1848     1849       +1     
===========================================
+ Hits          5478     5479       +1     
- Misses        3486     3489       +3     
  Partials       182      182              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d011b1d...8b18d62. Read the comment docs.

@brenopolanski
Copy link
Contributor

@alexbarnsley maybe you can change the text here too 👇 when to delete a contact:

Screenshot from 2020-03-05 09-43-43

@alexbarnsley
Copy link
Member Author

Nice spot. The message about passphrase isn't relevant either since it's just a contact 👍

@faustbrian faustbrian merged commit c5ca8eb into develop Mar 9, 2020
@ghost ghost deleted the refactor/delete-contact-button-wording branch March 9, 2020 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants