This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
refactor: replace moment with dayjs #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faustbrian
requested review from
alexbarnsley,
ItsANameToo and
luciorubeens
as code owners
ghost
added
Complexity: Low
Codecov Report
@@ Coverage Diff @@
## develop #1753 +/- ##
===========================================
- Coverage 59.90% 59.89% -0.02%
===========================================
Files 365 366 +1
Lines 9136 9145 +9
Branches 1847 1848 +1
===========================================
+ Hits 5473 5477 +4
- Misses 3483 3486 +3
- Partials 180 182 +2
Continue to review full report at Codecov.
|
dated
reviewed
Mar 2, 2020
Comment on lines
+40
to
+48
| if (userLanguage === 'en-us') { | ||
| userLanguage = 'en' | ||
| } | ||
|
|
||
| try { | ||
| require(`dayjs/locale/${userLanguage}`) | ||
| } catch { | ||
| userLanguage = 'en' | ||
| } |
There was a problem hiding this comment.
More generic:
Suggested change
| if (userLanguage === 'en-us') { | |
| userLanguage = 'en' | |
| } | |
| try { | |
| require(`dayjs/locale/${userLanguage}`) | |
| } catch { | |
| userLanguage = 'en' | |
| } | |
| const [language, region] = userLanguage.split('-') | |
| if ( | |
| (language === 'en' && region === 'us') || | |
| language === region | |
| ) { | |
| userLanguage = language | |
| } | |
| try { | |
| require(`dayjs/locale/${userLanguage}`) | |
| } catch { | |
| userLanguage = 'en' | |
| } |
There was a problem hiding this comment.
This will also handle locales like de-DE, it-IT ...
There was a problem hiding this comment.
Also more expensive due to how require works inside of electron.
There was a problem hiding this comment.
Gimme a minute, I'll boil it down to one require
|
|
alexbarnsley
approved these changes
Mar 4, 2020
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all occurrences of
momentwithdayjs.