This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
ci: draft releases when merging to master #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Medium
Codecov Report
@@ Coverage Diff @@
## develop #1693 +/- ##
========================================
Coverage 63.87% 63.87%
========================================
Files 139 139
Lines 3815 3815
Branches 797 797
========================================
Hits 2437 2437
Misses 1152 1152
Partials 226 226Continue to review full report at Codecov.
|
faustbrian
force-pushed
the
workflow-release
branch
2 times, most recently
from
bad59e7 to
c028314
Compare
faustbrian
force-pushed
the
workflow-release
branch
from
577b690 to
1e1c389
Compare
faustbrian
requested review from
alexbarnsley,
ItsANameToo and
luciorubeens
as code owners
ghost
added
Status: Needs Review
alexbarnsley
approved these changes
Feb 21, 2020
ghost
deleted the
ghost
removed
the
Status: Needs Review
|
unfortunately this breaks builds for win and macos on forks since the build steps depend on github secrets which, well... are secret. |
|
You'll still be busy another 8 weeks with tests so don't act like it's urgent @dated |
|
:cripes: |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafts a new release based on the
versionproperty in thepackage.jsonfile. The changelog is currently not automatically created but could be added if needed.It's important to use the versioning commands of
npmoryarnto ensure that the workflows and artifacts are properly versioned. Manually editing files should be avoided as those commands exist for a reason.This intentionally only runs on a push to master as what is merged should be 100% working based on tests and builds on
developpassing.