Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: scroll on menu tab, not on container #1641

Merged
merged 5 commits into from
Feb 24, 2020
Merged

refactor: scroll on menu tab, not on container #1641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3163eec
refactor: scroll on menu tab, not on container
dated Jan 30, 2020
cba23df
Merge branch 'develop' into refactor/menu-tab-scrolling
dated Jan 30, 2020
225c8f1
Merge branch 'develop' into refactor/menu-tab-scrolling
dated Jan 31, 2020
45c58e1
Merge branch 'develop' into refactor/menu-tab-scrolling
dated Feb 14, 2020
cb81804
Merge branch 'develop' into refactor/menu-tab-scrolling
alexbarnsley Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/renderer/components/Menu/MenuTab/MenuTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</button>
</div>
</nav>
<section class="MenuTab__content p-5">
<section class="MenuTab__content p-5 overflow-y-auto">
<slot />
</section>
</div>
Expand Down Expand Up @@ -92,6 +92,10 @@ export default {
</script>

<style lang="postcss" scoped>
.MenuTab {
@apply .flex .flex-col .h-full;
}

.MenuTab__nav__item--active {
@apply .bg-theme-switch-button .text-theme-button-text;
}
Expand Down
7 changes: 2 additions & 5 deletions src/renderer/components/Wallet/WalletDetails/WalletDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<template>
<main class="WalletDetails flex flex-col">
<WalletHeading class="sticky pin-t z-10" />
<WalletHeading />

<MenuTab
ref="menutab"
v-model="currentTab"
:class="{ 'rounded-bl-lg' : !isDelegatesTab || !isOwned }"
class="flex-1 overflow-y-auto"
class="flex-1"
>
<MenuTabItem
key="BackItem"
Expand Down Expand Up @@ -519,9 +519,6 @@ export default {
</script>

<style lang="postcss">
.WalletDetails .MenuTab > .MenuTab__nav {
@apply .sticky .pin-t .z-10
}
.WalletDetails__button {
transition: 0.5s;
cursor: pointer;
Expand Down