Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix(plugins): vue package in production #1536

Merged
merged 5 commits into from
Nov 8, 2019
Merged

fix(plugins): vue package in production #1536

merged 5 commits into from
Nov 8, 2019

Conversation

luciorubeens
Copy link
Contributor

Summary

Fixes #1534

Add a second VM to read the main file and compile the template.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. Status: In Progress The issue or pull request is being worked on. labels Nov 5, 2019
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #1536 into develop will increase coverage by 0.24%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1536      +/-   ##
===========================================
+ Coverage    45.44%   45.68%   +0.24%     
===========================================
  Files          274      274              
  Lines         6806     6807       +1     
  Branches      1326     1326              
===========================================
+ Hits          3093     3110      +17     
+ Misses        3550     3535      -15     
+ Partials       163      162       -1
Impacted Files Coverage Δ
.../services/plugin-manager/setup/components-setup.js 92.85% <ø> (ø) ⬆️
...c/renderer/services/plugin-manager/plugin-setup.js 0% <0%> (ø) ⬆️
...renderer/services/plugin-manager/plugin-sandbox.js 94.44% <66.66%> (+94.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2211f...04f1cdb. Read the comment docs.

@luciorubeens luciorubeens marked this pull request as ready for review November 6, 2019 16:57
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Nov 6, 2019
@luciorubeens luciorubeens changed the title [WIP] fix(plugins): vue package in production fix(plugins): vue package in production Nov 6, 2019
Copy link
Member

@alexbarnsley alexbarnsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't run a build which was done locally, but the artifact worked as expected 👌

@alexbarnsley alexbarnsley merged commit 4ccc13b into develop Nov 8, 2019
@ghost ghost deleted the fix/vue-prod branch November 8, 2019 12:43
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use any plugins
3 participants