This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: provide default port when adding custom network #1510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a custom network fails if the seed server has no port. This PR provides default values if the port is missing.
Regarding the changes made to:
If
this.host
contains no port,matches
isnull
andconst scheme = matches[1]
throws a type error. Checking againstmatches[3]
afterwards is useless at this point.Checklist