This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
refactor(plugins): add destroy method and binary websocket support #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Low
ghost
mentioned this pull request
alessiodf
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
ghost
added
Status: Needs Review
alessiodf
changed the title
luciorubeens
approved these changes
Oct 30, 2019
ghost
added
the
Status: Member Approved
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
luciorubeens
added
the
Bounty: Tier 4
|
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
ghost
removed
the
Status: Needs Review
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1497 and fixes #1493 and includes appropriate tests. Also confirmed the described memory leak in #1497 is resolved.
Checklist