refactor(plugins): add destroy method and binary websocket (#1500)

__tests__/unit/services/plugin-manager/sandbox/websocket-sandbox.spec.js

@@ -105,6 +105,13 @@ describe('PluginWebsocket', () => {
     socket.send('ping')
   })
 
+  it('should change the binary type to arraybuffer', () => {
+    const socket = walletApi.websocket.connect(host)
+
+    socket.binaryType = 'arraybuffer'
+    expect(socket.binaryType).toBe('arraybuffer')
+  })
+
   it('should close the websocket', (done) => {
     const socket = walletApi.websocket.connect(host)
 
@@ -152,6 +159,12 @@ describe('PluginWebsocket', () => {
     }).toThrow('URL "ws://my.test.com:8081" not allowed')
   })
 
+  it('should destroy the socket', () => {
+    const socket = walletApi.websocket.connect(host)
+    socket.destroy()
+    expect(socket.isDestroyed()).toBeTrue()
+  })
+
   it('should ignore an invalid whitelist', () => {
     expect(() => {
       const api = {}

src/renderer/services/plugin-manager/sandbox/websocket-sandbox.js

@@ -27,7 +27,7 @@ class PluginWebsocket {
   connect (url) {
     this.validateUrl(url)
 
-    const websocket = new WebSocket(url)
+    let websocket = new WebSocket(url)
 
     const websocketEvents = {
       events: [],
@@ -42,7 +42,7 @@ class PluginWebsocket {
       on (action, eventCallback) {
         const eventTrigger = event => {
           const result = {}
-          if (event.data && event.data !== Object(event.data)) {
+          if (event.data) {
             result.data = event.data
           }
 
@@ -63,34 +63,55 @@ class PluginWebsocket {
         this.events[action] = eventTrigger
       },
 
+      get binaryType () {
+        return websocket && websocket.binaryType
+      },
+
+      set binaryType (type) {
+        websocket.binaryType = type
+      },
+
       close () {
         websocket.close()
       },
 
+      destroy () {
+        if (websocket) {
+          if (!websocketEvents.isClosing() && !websocketEvents.isClosed()) {
+            websocket.close()
+          }
+          websocketEvents.clear()
+        }
+        websocket = null
+      },
+
       send (data) {
         websocket.send(data)
       },
 
       isConnecting () {
-        return websocket.readyState === WebSocket.CONNECTING
+        return websocket && websocket.readyState === WebSocket.CONNECTING
+      },
+
+      isDestroyed () {
+        return websocket === null
       },
 
       isOpen () {
-        return websocket.readyState === WebSocket.OPEN
+        return websocket && websocket.readyState === WebSocket.OPEN
       },
 
       isClosing () {
-        return websocket.readyState === WebSocket.CLOSING
+        return websocket && websocket.readyState === WebSocket.CLOSING
       },
 
       isClosed () {
-        return websocket.readyState === WebSocket.CLOSED
+        return websocket && websocket.readyState === WebSocket.CLOSED
       }
     }
 
     this.router.beforeEach((_, __, next) => {
-      websocketEvents.clear()
-      websocket.close()
+      websocketEvents.destroy()
       next()
     })