Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to extend core-api responses #3571

Closed
air1one opened this issue Mar 4, 2020 · 1 comment
Closed

Allow to extend core-api responses #3571

air1one opened this issue Mar 4, 2020 · 1 comment
Assignees

Comments

@air1one
Copy link
Contributor

air1one commented Mar 4, 2020

Bridgechains may want to modify api responses from existing core-api endpoints, for example removing fields that don't make sense to them.

For example recently in 2.6 we had default dynamic fees set up for all kind of transactions in the transaction pool config.
Those default fees were picked up and showed in api/node/configuration endpoint which does not make sense for bridgechains for magistrate related fees as they don't have magistrate transactions.

Then allowing to extend core-api responses can help bridgechains to adapt api to their own needs.

@air1one air1one added this to the 3.0.0 milestone Mar 4, 2020
@faustbrian faustbrian removed this from the 3.0.0 milestone Jun 19, 2020
@sebastijankuzner
Copy link
Contributor

sebastijankuzner commented Jul 10, 2020

If the problem are only excess fields, then we can provide ability to extend resource objects packages/core-api/src/resources. Another variant is using hapi plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants