Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement toString method in base transaction class #3529

Closed
rainydio opened this issue Feb 24, 2020 · 1 comment
Closed

Implement toString method in base transaction class #3529

rainydio opened this issue Feb 24, 2020 · 1 comment
Assignees
@rainydio

Comments

@rainydio
Copy link
Contributor

rainydio commented Feb 24, 2020 •
edited
Loading

Current Behavior

Most log lines only include transaction id. It's difficult to understand what exactly is going on.

Expected Behavior

Human-friendly description may include sender address, nonce, transaction type, and some type-specific fields.

Possible Solution

Implement toString method in base transaction class.

Context

When tests are executed pool is generating a lot of log lines. But it's difficult to read them and debug if something goes wrong.
@rainydio rainydio mentioned this issue Feb 24, 2020
Merged
2 tasks
@rainydio rainydio self-assigned this Feb 24, 2020
@rainydio rainydio changed the title Add describeTransaction method to transaction handler Add toString method to base transaction class Feb 26, 2020
@rainydio rainydio changed the title Add toString method to base transaction class Implement toString method in base transaction class Feb 26, 2020
@rainydio rainydio mentioned this issue Feb 26, 2020
Merged
3 tasks
@rainydio
Copy link
Contributor Author

Merged

@ghost ghost mentioned this issue Mar 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rainydio rainydio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rainydio