Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magistrate websites and repositories can be localhost #3294

Closed
dated opened this issue Nov 22, 2019 · 8 comments
Closed

magistrate websites and repositories can be localhost #3294

dated opened this issue Nov 22, 2019 · 8 comments

Comments

@dated
Copy link
Contributor

dated commented Nov 22, 2019

When registering a bridgechain the repository url is validated only against the uri schema, which does not check against localhost.

The repository url should not be allowed to contain anything localhost'y.

The same schema is used for a business repository and website.

@ghost
Copy link

ghost commented Nov 22, 2019

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@dated dated changed the title bridgechain repository can be localhost magistrate websites and repositories can be localhost Nov 22, 2019
@faustbrian faustbrian changed the title magistrate websites and repositories can be localhost [2.6][T4] magistrate websites and repositories can be localhost Nov 28, 2019
@dated
Copy link
Contributor Author

dated commented Dec 13, 2019

This could be restricted even further to allow only uris where the hostname is not an ip, besides not being localhost. Any preference @faustbrian?

@faustbrian
Copy link
Contributor

@dated

@air1one
Copy link
Contributor

air1one commented Jan 7, 2020

Hey @dated we talked a bit and it does not "hurt" to let people register localhost, if they want to pay business fee + bridgechain fee to register a stupid name then so be it 😄

Closing this, don't hesitate to talk to me if you feel this should be re-opened.

@air1one air1one closed this as completed Jan 7, 2020
@ghost
Copy link

ghost commented Jan 7, 2020

This issue has been closed. If you wish to re-open it please provide additional information.

@dated
Copy link
Contributor Author

dated commented Jan 7, 2020

I'm fine with this decision, no worries. The business website and repository can be updated however, while a bridgechain repository cannot. This should be reconsidered imho.

@dated
Copy link
Contributor Author

dated commented Jan 7, 2020

The Tier should probably be removed at this point @faustbrian.

@air1one
Copy link
Contributor

air1one commented Jan 8, 2020

The business website and repository can be updated however, while a bridgechain repository cannot. This should be reconsidered imho.

Yes this is pending here #3375 👌

@dated dated changed the title [2.6][T4] magistrate websites and repositories can be localhost magistrate websites and repositories can be localhost Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants