-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magistrate websites and repositories can be localhost #3294
Comments
Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
This could be restricted even further to allow only uris where the hostname is not an ip, besides not being |
Hey @dated we talked a bit and it does not "hurt" to let people register localhost, if they want to pay business fee + bridgechain fee to register a stupid name then so be it 😄 Closing this, don't hesitate to talk to me if you feel this should be re-opened. |
This issue has been closed. If you wish to re-open it please provide additional information. |
I'm fine with this decision, no worries. The business website and repository can be updated however, while a bridgechain repository cannot. This should be reconsidered imho. |
The Tier should probably be removed at this point @faustbrian. |
Yes this is pending here #3375 👌 |
When registering a bridgechain the repository url is validated only against the
uri
schema, which does not check against localhost.The repository url should not be allowed to contain anything localhost'y.
The same schema is used for a business repository and website.
The text was updated successfully, but these errors were encountered: