Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database details and credentials #3286

Closed
deanpress opened this issue Nov 19, 2019 · 3 comments
Closed

Database details and credentials #3286

deanpress opened this issue Nov 19, 2019 · 3 comments

Comments

@deanpress
Copy link
Contributor

deanpress commented Nov 19, 2019

Configuring a database using bash install.sh or ./bin/run database:configure doesn't appear to add the details/credentials to the envfiles that are utilized by the node when running e.g. yarn full:testnet.

Furthermore, setup.ts for integration tests (https://github.com/ArkEcosystem/core/blob/develop/__tests__/integration/core-database-postgres/__support__/setup.ts) requires a specific database with specific user credentials to exist. If the db or user doesn't exist, the test fails.

Currently I have to:

  1. Configure the db details in the envfile for each network that I intend to use
  2. Configure the db details for the integration tests' testnet and unitnet configs
  3. Configure the db connection in https://github.com/ArkEcosystem/core/blob/develop/__tests__/integration/core-database-postgres/__support__/setup.ts

If I'm not missing a step with the generation or management of these databases (I create/manage them myself with pgadmin and manually configure the envfiles), then creation and management of databases could be easier.

Your Environment

  • Version used: 2.6
  • Operating System and version: Ubuntu 19
@ghost
Copy link

ghost commented Nov 19, 2019

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@faustbrian
Copy link
Contributor

The full:testnet command is intended for development while the configuration steps in the install.sh are for production installations via NPM releases. If you want to develop things you should either use our docker preset for unitnet (which is the easiest) or manually setup a database with the same credentials as that uses.

If you want to develop something then you should follow and use what is shipped with core for the testing setup. If you want to deviate from that than you're on your own and have to make necessary changes.

@ghost
Copy link

ghost commented Nov 20, 2019

This issue has been closed. If you wish to re-open it please provide additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants