[2.6][T4] type of lockTransactionId in transaction schemas

[dated]

lockTransactionId is defined as follows in the transaction schemas:

core/packages/crypto/src/transactions/types/schemas.ts

Line 288 in 9800e34

lockTransactionId: { allOf: [{ minLength: 64, maxLength: 64 }, { $ref: "hex" }] },

core/packages/crypto/src/transactions/types/schemas.ts

Line 311 in 9800e34

lockTransactionId: { allOf: [{ minLength: 64, maxLength: 64 }, { $ref: "hex" }] },

Since lockTransactionId is a reference to a transaction id, the respective types should be the same. Strictly speaking this is currently not the case, with hex being a subset of alphanumeric.

core/packages/crypto/src/validation/schemas.ts

Lines 20 to 23 in 9800e34

	transactionId: {
	$id: "transactionId",
	allOf: [{ minLength: 64, maxLength: 64 }, { $ref: "alphanumeric" }],
	},

lockTransactionId should be defined as

lockTransactionId: { $ref: "transactionId" }

Also, wouldn't hex instead of alphanumeric suffice as a constraint on transactionId?

[ghost]

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

[ghost]

This issue has been closed. If you wish to re-open it please provide additional information.