Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6][T4] Misleading error message when updating a bridgechain not registered by the same business #3123

Closed
Lemii opened this issue Oct 25, 2019 · 8 comments
Assignees

Comments

@Lemii
Copy link
Contributor

Lemii commented Oct 25, 2019

Summary
When a business tries to update an existing bridgechain / ID that has not been registered with the same account, the following error is returned:

[
  {
    "type": "ERR_APPLY",
    "message": "Failed to apply transaction, because bridgechain is not registered error."
  }
]

This message implies that the bridgechain is not registered at all (it returns the same message when that is the case), while the issue it actually that the user is not the owner of the bridgechain.

Expected Behavior
Return a more accurate error message, describing that the account is not the owner of the bridgechain.

Your Environment
Devnet 2.6

@ghost
Copy link

ghost commented Oct 25, 2019

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@Lemii Lemii changed the title Misleading error message when updating bridgechain not registered by user Misleading error message when updating a bridgechain not registered by the same business Oct 25, 2019
@faustbrian faustbrian changed the title Misleading error message when updating a bridgechain not registered by the same business [2.6][T4] Misleading error message when updating a bridgechain not registered by the same business Oct 25, 2019
@ghost
Copy link

ghost commented Oct 25, 2019

This issue or pull request needs further investigation. Please wait for further information, thank you.

@KovacZan
Copy link
Contributor

Do you want to change error message to be more accurate?

@Lemii
Copy link
Contributor Author

Lemii commented Oct 25, 2019

Do you want to change error message to be more accurate?

Not sure if it's aimed at me, but I'll reply anyway :)

Let's imagine you're a business owner running one or more bridgechains. You want to update a bridgechain, but you made a small error by entering an incorrect ID.. when you send the update, you get an error message bridgechain is not registered.

I believe that this will be very confusing to the business owner, because in his experience his bridgechain is registered. After seeing such message, he might think something is wrong with the system or that he broke something, even though the issue is nothing to worry about and he just entered the incorrect ID.

So yeah, I believe it would be beneficial to the user experience to change the error message to something more accurate 👍

@faustbrian
Copy link
Contributor

@Lemii the questions was more if you would like to fix the issue by submitting a PR for it.

@Lemii
Copy link
Contributor Author

Lemii commented Oct 25, 2019

@faustbrian Sure, will do 👍

@faustbrian
Copy link
Contributor

Great, assigned you to the issue.

@ghost
Copy link

ghost commented Oct 27, 2019

This issue has been closed. If you wish to re-open it please provide additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants