Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sugestion - minimize docker's entrypoint #2819

Closed
ksemaev opened this issue Jul 16, 2019 · 4 comments
Closed

Sugestion - minimize docker's entrypoint #2819

ksemaev opened this issue Jul 16, 2019 · 4 comments

Comments

@ksemaev
Copy link

ksemaev commented Jul 16, 2019

Let's move those lines https://github.com/ArkEcosystem/core/blob/master/docker/production/entrypoint.sh#L4-L7 into dockerfile, since they have to run anyway?

Also I would suggest remove that line - https://github.com/ArkEcosystem/core/blob/master/docker/production/Dockerfile#L15 as I don't need to have sudo for relay, and it works fine for me now.
I suspect that with a little tweaking we can avoid sudo for forger as well

@ghost
Copy link

ghost commented Jul 16, 2019

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@faustbrian
Copy link
Contributor

The /etc/sudoers line doesn't get added to run your relay or forger. It gets added so certain tasks can be executed without user interaction like installing, updating, running ntpd or using sudo to force delete some Core directories.

@ghost
Copy link

ghost commented Jul 17, 2019

This issue has been closed. If you wish to re-open it please provide additional information.

@ksemaev
Copy link
Author

ksemaev commented Jul 17, 2019

@faustbrian it's like you're so defensive of current settings that you don't even consider of making anything better. In the files above I showed you that the Core directories are in node user's folder and can be deleted by node + it all can be done inside dockerfile.
Having sudo inside docker is a very bad practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants