-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(smolagents): add entrypoint for use in opentelemetry-instrument #1276
Conversation
Signed-off-by: Adrian Cole <[email protected]>
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! TIL! Thanks for the contribution. lgtm!
Just verified this works like a champ with latest release. Should I raise PRs for the others? If so, same PR for all others, or one each like this? |
Thanks so much for this @codefromthecrypt can do them all at once no problem. We have a single release please pipeline now. Should just work |
ok I may be somewhat blind now, but all the rest are done in #1278 ;) |
@codefromthecrypt maintainer of smolagents here: could you explain what this changes for instrumentation, and if we have actions to take to make it work? |
Hi @aymeric-roucher ! As far as I understand, this doesn't change anything with the existing instrumentation for smolagents. It just gives users more optionality for setting up smolagents instrumentation with their apps, by allowing them to remove some boilerplate otel instrumentation code (via a run time arg instead) , if they so desire. |
@aymeric-roucher I concur with @nate-mar and was going to propose an instruction change PR today for smolagents repo. You can then assess that to see if you prefer the before or after, but the existing instructions still work! |
I mentioned this to @mikeldking, that openinference can become automatically enabled with opentelemetry's zero code approach for python, by adding entrypoints into the pyproject.toml.
Specifically, after this, as long as you have the dependencies of your main code, plus openinference-instrumentation-smolagents, and env exported with standard variables, if you launch with
opentelemetry-instrument
, traces will magically appear.Before adding to all projects, I wanted to check with smolagents first, if this is ok with y'all. I would love to be able to showcase this with Elastic Distribution of OpenTelemetry (EDOT) and the diff makes it all perfectly invisible.