Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify diffstar kernel to return log_mah in addition to sfr #66

Open
aphearin opened this issue Aug 29, 2024 · 0 comments
Open

Modify diffstar kernel to return log_mah in addition to sfr #66

aphearin opened this issue Aug 29, 2024 · 0 comments
Assignees

Comments

@aphearin
Copy link
Contributor

The _lax_ms_sfh_scalar_kern_scan function is the core kernel where a scalar value of diffstar SFR is computed. Currently, this kernel computes log_mah from the diffmah parameters, and then sfr from the diffstar parameters, but the kernel only returns sfr, and so if we need log_mah in addition to sfh then we'd need to recompute log_mah, which is inefficient and clunky. The fix is to have this scalar kernel return both log_mah and sfr, but that will break a lot of downstream code. And so we might should wait on this change until we do some other code restructuring in diffmah such as ArgonneCPAC/diffmah#134 and ArgonneCPAC/diffmah#135.

@aphearin aphearin self-assigned this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant