You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The _lax_ms_sfh_scalar_kern_scan function is the core kernel where a scalar value of diffstar SFR is computed. Currently, this kernel computes log_mah from the diffmah parameters, and then sfr from the diffstar parameters, but the kernel only returns sfr, and so if we need log_mah in addition to sfh then we'd need to recompute log_mah, which is inefficient and clunky. The fix is to have this scalar kernel return both log_mah and sfr, but that will break a lot of downstream code. And so we might should wait on this change until we do some other code restructuring in diffmah such as ArgonneCPAC/diffmah#134 and ArgonneCPAC/diffmah#135.
The text was updated successfully, but these errors were encountered:
The _lax_ms_sfh_scalar_kern_scan function is the core kernel where a scalar value of diffstar SFR is computed. Currently, this kernel computes
log_mah
from the diffmah parameters, and thensfr
from the diffstar parameters, but the kernel only returnssfr
, and so if we needlog_mah
in addition tosfh
then we'd need to recomputelog_mah
, which is inefficient and clunky. The fix is to have this scalar kernel return bothlog_mah
andsfr
, but that will break a lot of downstream code. And so we might should wait on this change until we do some other code restructuring in diffmah such as ArgonneCPAC/diffmah#134 and ArgonneCPAC/diffmah#135.The text was updated successfully, but these errors were encountered: