Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Filing documents download doesn't work with report packages #542

Open
paulwarren-wk opened this issue Jul 26, 2023 · 2 comments
Open
Labels
bug Something isn't working

Comments

@paulwarren-wk
Copy link
Contributor

What happened?

If you create a viewer from a ZIP file with no directory structure, the "download filing documents" link will be present on the viewer settings menu. If you create a viewer from a report package, the menu option is not present.

The code currently checks that the parent directory of the filing path ends in .zip which isn't the case in a report package due to the additional directory structure within the ZIP.

Version

1.1.147

With which browsers are you experiencing the bug?

Chrome

Documents

No response

Screenshots

No response

@paulwarren-wk paulwarren-wk added the bug Something isn't working label Jul 26, 2023
@paulwarren-wk
Copy link
Contributor Author

When fixing this, we might consider also adding an option to disable the "download filing documents" behaviour. ESEF report packages can be very large, and this feature makes a copy of the file being linked to.

@brettkail-wk
Copy link
Contributor

I'd suggest removing the support for embedding the original ZIP (I'd be surprised if anyone wants that) and instead add a non-default --download-url option that allows specifying a separate external download URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants