Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rover: replace arming-required with auto-arm-when-ready feature #28644

Open
rmackay9 opened this issue Nov 16, 2024 · 0 comments
Open

Rover: replace arming-required with auto-arm-when-ready feature #28644

rmackay9 opened this issue Nov 16, 2024 · 0 comments

Comments

@rmackay9
Copy link
Contributor

Rover has an arming-required parameter which can be set to false allowing the vehicle to be in an armed state even though it hasn't passed the arming checks. I'm not a fan of this because it forces us to implement checks in other places to confirm the vehicle doesn't behave badly when it's in an unsafe state (e.g. Auto mode needs to double check that it has a position estimate). Implementing these checks here and there is error prone.

A better solution could be to remove the arming-required parameter and instead add an auto-arm feature which automatically arms the vehicle once it has passes arming checks.

This issue comes from this discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant