Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do list / Issue (problems) list #3

Closed
17 of 21 tasks
m0d16l14n1 opened this issue Oct 11, 2020 · 94 comments
Closed
17 of 21 tasks

To-do list / Issue (problems) list #3

m0d16l14n1 opened this issue Oct 11, 2020 · 94 comments
Labels
question Further information is requested

Comments

@m0d16l14n1
Copy link
Collaborator

m0d16l14n1 commented Oct 11, 2020

  • Black screen bug after boot process (glitching/blinking and etc in other Ice Lake laptops)
  • HDMI issues (Type-C to HDMI is working okay)
  • Issues with HDMI audio (through Type-C to HDMI dongles) - it's not working at all. Need to investigate this
  • Audio issues (get the rid of faking device-id + fix headphones)
  • Touchpad isn't working after sleep-wake cycle
  • Touchpad isn't working after hot reboot from Windows/Linux
  • Power button isn't working at all, or working randomly (using YogaSMC.kext fixed that issue)
  • Sound is not working after reboot or shutdown from Windows
  • Random glitch with the cursor (sometimes it's glitching like it's in a low resolution, sleep cycle can fix that)
  • Check other available framebuffers for Ice Lakes (currently only to tested - default one (0x8A520000 - not working properly with sleep) and (0x8A5C0002 / 0x8A510002 (default MacBookAir9,1) - current framebuffer list with properly working wake after sleep)
  • Test hibernation (fixed, working modes 3 and 25)
  • Thunderbolt 3 - working without support of hotplug
  • Get the rid of brightness patches (using YogaSMC to get that keys working without patches)
  • Get the rid of H_EC rename to EC (afaik it's not safe to use that kind of renames, already did on my EFI)
  • Need to understand what OEM laptop we have (Clevo/Tongfang/IP3 Technology), just for BIOS updates and other stuff
  • Check ALL settings of the BIOS, many of them might be helpfull for Hackintosh
  • Undervolting or set some settings (example: fan settings) to get lower temperature (75-88* while installing XCode even with new thermal paste - that's really not "safe") > possible to set lower turbo options and other stuff in unlocked BIOS)
  • Cosmetics stuff (it's actually useless, but easy to do with Hackintool, for example)
  • Line-in is still WIP
  • Realtek microSD-card reader not working at all. There is a workaround with method of VM passthrough, but better to disable it at all #8

New problems:

  • HiDPi problem - screen is blinking if you use any browser to play youtube / or just some graphic stuff (i got blinking screen if i use XCode + browsing github. As i`ve already mentioned - the problem with WindowServer (in Activity Monitor it has too many processes + too many CPU (over 99-130%, very strange)

You can add something what i forgot to mention

@m0d16l14n1 m0d16l14n1 pinned this issue Oct 11, 2020
@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Oct 12, 2020

Audio is fixed for now (working without FakePCIID stuff + with no pci device inject, don't forget to remove that stuff from your EFI)
Still need to fix layout for headphones
Thx to @zhen-zen and @fewtarius - https://github.com/fewtarius/AppleALC/commit/1dbba6491ea94eeef98b322254133d2f3e166f15
AppleALC.kext.zip

@Ardentwheel
Copy link
Owner

Audio is fixed for now (working without FakePCIID stuff + with no pci device inject, don't forget to remove that stuff from your EFI)
Still need to fix layout for headphones
Thx to @zhen-zen and @fewtarius - fewtarius/AppleALC@1dbba64
AppleALC.kext.zip

Yes, I tested the patch, now working without FakePCIID.
And I made a pull request acidanthera/AppleALC#613

@m0d16l14n1
Copy link
Collaborator Author

@Ardentwheel is your 18 layout fixed problem with Headphones?

@m0d16l14n1
Copy link
Collaborator Author

btw, audio is dead randomly after wake-sleep cycles, might we need hpet fix, or it's might be layout problem

@ghost
Copy link

ghost commented Oct 13, 2020

btw, audio is dead randomly after wake-sleep cycles, might we need hpet fix, or it's might be layout problem

My gist that I linked you to previously may correct that.

https://gist.github.com/fewtarius/0ee689cf725c27c43af0aea83b04b882

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Oct 13, 2020

My gist that I linked you to previously may correct that.

yeah, currently I did fix for hpet sound is okay after sleep. if there any problems more - I will sure did the things from your guide, especially about headphones, heh

fixed hpet.zip

@ghost
Copy link

ghost commented Oct 13, 2020

The gist may also fix no sound after sleep for internal devices, it can be EAPD related.

@m0d16l14n1
Copy link
Collaborator Author

Made some sleep-wake cycles, sound seems working okay now, still need to test it more

@m0d16l14n1
Copy link
Collaborator Author

The gist may also fix no sound after sleep for internal devices, it can be EAPD related.

oh, got it. okay

@Ardentwheel
Copy link
Owner

Ardentwheel commented Oct 14, 2020

headphone jack is connect via external line, dose have something to do with it ?

IMG_0374

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Oct 14, 2020

Wi-Fi speeds over 5ghz on BCM94360NG has been fixed with using AirportBrcmFixup, i don't know why speeds are low by default, maybe it's problem with CNVI 2, which we have in our laptop. But at least it's working properly now.

On windows by default speed are okay with latest Fenvi drivers from their website. Router settings are set properly, i even tried to set aspm-default values, but that didn't work for macOS to work properly at 5ghz.

Only with the kext it's working with ~ same speed as in windows by default

@m0d16l14n1
Copy link
Collaborator Author

headphone jack is connect via external line, dose have something to do with it ?

there should be no problem with that, that's usual way to connect usb/hp board to main board. nothing special

@ghost
Copy link

ghost commented Oct 16, 2020

FYI - I've submitted the PR for the controller patch, it seems to also correct a no audio issue for someone with a Dell 7390.

acidanthera/AppleALC#615

@m0d16l14n1
Copy link
Collaborator Author

@fewtarius thanks!!

@m0d16l14n1
Copy link
Collaborator Author

The HDMI issue might be fixed with new patch from FireWolf - acidanthera/WhateverGreen#72
Once it will be merged - need to try it

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Oct 17, 2020

About undervolting and stuff - seems to be possible to use undervolting (voltageshift) according to that guys - https://github.com/leon0410898/XPS13-9300-hackintosh

We have good bios and i see that stuff inside it (undervolt cpu, and modify PL1, PL2), so that's might be possible to make that without voltageshift at all.

Currently i just decreased turbo stuff from 3.6 ghz to 2.5 and temperatures now are fully okay (60-70*)

@0xFireWolf
Copy link

The HDMI issue might be fixed with new patch from FireWolf - acidanthera/WhateverGreen#72
Once it will be merged - need to try it

No, that PR is not related to HDMI on Ice Lake platforms.

The HDMI issue (not DisplayPort-over-Type-C to HDMI) is a complete new story.

Apple has removed HDMI support from the driver. While there are some leftover code related to HDMI in the driver, it is still unknown whether we could port the support back.

@m0d16l14n1
Copy link
Collaborator Author

No, that PR is not related to HDMI on Ice Lake platforms.

The HDMI issue (not DisplayPort-over-Type-C to HDMI) is a complete new story.

Apple has removed HDMI support from the driver. While there are some leftover code related to HDMI in the driver, it is still unknown whether we could port the support back.

got it, okay, wow...
thanks for the info, bad news :(
will hope for HDMI support than, heh.

@xenonstride
Copy link

Text on the screen is really small, sometimes it's hard to read compare to Windows global scale to 125%. Is there any way to make it bigger?
@m0d16l14n1 I used this website (https://comsysto.github.io/Display-Override-PropertyList-File-Parser-and-Generator-with-HiDPI-Support-For-Scaled-Resolutions/) to enable HiDPI and solve this issue which I also had

@Ardentwheel
Copy link
Owner

i use https://github.com/xzhih/one-key-hidpi
and the screen goes black, in recovery mode to delete 9e5 folder and replace icons.plist

@m0d16l14n1
Copy link
Collaborator Author

@Ardentwheel just put laptop to sleep and wake it, that's fix that issue with black screen

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Oct 19, 2020

With latest Lilu and WhateverGreen i can't boot installer of Big Sur at all. Previously it stucked on WhateverGreen patching, now it's booting to logo, keep loading for 1 minute and automatically reboot. Strange

UPDATE: I did update all kexts, including OC 0.6.3 and tried to install latest Big Sur Beta 10 (before i tried beta 6), seems to be working now, at least no reboot, waiting for installer to boot

UPDATE2: Successfully installed, seems to be working ok
Screenshot at Oct 19 22-44-53

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Oct 21, 2020

Sleep with closing lid seems to be fixed with the update to Big Sur, now it's working properly. Power button is still unresponsible

p.s Cursor glitching seems to be fixed too.

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Oct 28, 2020

Got the glitch of Apple logo to disappear after half of progress bar is done (Catalina-Big Sur beta 10) - after update to Big Sur 11,0,1 beta that's seems to be fixed. Now Apple logo not disappearing until progress bar fully loaded, after that i got black screen for 5-7 seconds and login screen appear. that's might be still strange, but something changed, heh

@m0d16l14n1
Copy link
Collaborator Author

VoodooI2C/VoodooI2C#399

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Nov 20, 2020

  • Get the rid of brightness patches > better move to BrightnessKeys.kext / but i am not sure how to do that

acidanthera/bugtracker#1309

@Ab2774
Copy link

Ab2774 commented Nov 20, 2020

  • Get the rid of brightness patches > better move to BrightnessKeys.kext / but i am not sure how to do that

Hi @m0d16l14n1, have you tried YogaSMC? It has built-in brightness keys support and many Lenovo laptop features like Conversation Mode and Fn Lock Mode.
Good luck.

@m0d16l14n1
Copy link
Collaborator Author

Hi @m0d16l14n1, have you tried YogaSMC? It has built-in brightness keys support and many Lenovo laptops features like Conversation Mode and Fn lock.
Good luck.

Isn't that supported for Lenovo laptops only?

@Bhavinjain260
Copy link

@m0d16l14n1 https://github.com/hackintosh-stuff/ComboJack even for me headphone mic wasn't working with this its working

@m0d16l14n1
Copy link
Collaborator Author

@m0d16l14n1 https://github.com/hackintosh-stuff/ComboJack even for me headphone mic wasn't working with this its working

i have already tried that method. that didn't work in our case at all. You probably have dell laptop, that's why it worked for you, heh. Thanks, anyway.

@Bhavinjain260
Copy link

@m0d16l14n1 a quick question are you able to switch between headphone and internal speaker even when headphone is connected??

@Ardentwheel
Copy link
Owner

@Ardentwheel btw, it's seems that in master branch Tools folder (where were dumps/BIOS and other stuff) is borked, now that folder is duplicate of OC > Tools folder.

Thank you, now fixed.

@m0d16l14n1
Copy link
Collaborator Author

@m0d16l14n1 a quick question are you able to switch between headphone and internal speaker even when headphone is connected??

yep

@m0d16l14n1
Copy link
Collaborator Author

Changed ig-platform-id to 0x8A530002
Working as good as previous one. Added -igfxmlr just to test it again and now it's working actually. Previously i just got black screen. Will attach logs here. Also i did update my fork with logs folder, will use it now.

Actually there are some "errors" in WEG log, because of -igfxmpc as example.
logs-with-mlr.zip
logs-without.zip

@m0d16l14n1
Copy link
Collaborator Author

@Ardentwheel

Audio is finally seems to be fixed. With new created platform and pin config (made by @agasecond from AppleLife.ru) internal speakers working as good as in Windows + after inserting headphones in jack - it's automatically disabling internal speakers and switching to headphones. After unplugging headphones - internal speakers goes back to work. Sound is working great. There is still problem with Line-in (it's not working at all right now), but i might be able to discover that and fix too (i hope that's possible).

Right now @agasecond find the way to fix that via correct pin config, so we don't need use ComboJack/CodecCommander and other stuff like ALCPlugFix and etc. So i hope it will be possible to fix jack mic in the same way, but it's still unknown if it's possible.

Once test period will pass - @agasecond will push pull request with new layout for our laptop, which will include that headphone switching fix

@m0d16l14n1
Copy link
Collaborator Author

Here is gitter chat for Ice Lake owners, created by @Lorys89

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Feb 8, 2021

"New" news about sound/other (forgot to mention that before)

  • Sound is now working on macOS after reboot or shutdown from Windows
  • Currently touchpad not working from hot reboot from Windows/Linux, you still need to shutdown from Windows/Linux to get it working in macOS (but now at least sound will work 100% after Windows reboot/shutdown).
  • Line-in is still a problem

Also, @kingo132 found those boot-args in our graphics kexts, so it might be good to test them out (some of them)

---> AppleIntelICLLPGraphicsFramebuffer.kext
auxDelay
-10bpc
ig
-nodisplaysleepDC6
-noDC9
-linp0
dither=[0/1]
-yTileDisable
-nocam
-disable3d
dc6config=[0/1/2/3/5]
-forceDSC
forceRenderStandby=[0/1] Default is 0
-disablegfxfirmware
-nossc
EnableLPVPonExternal=[0/1] Default is0
-disableDynamicCDClk
-noasfu
GPU420Support=[0/1] Default is0
EnableGPUSubSamplingForHDR=[0/1] Default is0
enablefp16=[0/1] Default is0
-2dsim (2D GPU simulation)
-DisableIOFB
-panic_on_unload
-noCustomAux
meibootarg=[0/1] Default is0
tcncontrol Default is 0
-nopsr
-nopsrexit
-novrr
-nodpb
-sfu
-forcepsr
dpbmode

---> AppleIntelICLGraphics.kext
-noig
-allow3d
-disablegfxpreemption
-disablegfxfirmware

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Feb 14, 2021

Touchpad not working after hot reboot from Windows is now fixed

Here are details

After that change (SYNA3602 > ALPS0001) in VoodooI2CHID.kext/Info.plist file touchpad is working after reboots from Windows/Linux. Now system is fully stable after reboots from other OSes (sound and touchpad are fully working)

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Feb 17, 2021

@Ardentwheel
Some updates regarding touchpad (the news above). I just did the rename patch for our touchpad, because I don't want to change the name in Info.plist every time i update VoodooI2C kexts. If you want - you can use that method, or just method above, no difference.

ACPI > Patch (that's just replacing ALPS0001 to SYNA3602 in DSDT itself)
Find: 414C5053 30303031
Replace: 53594E41 33363032

p.s. found out that you already did that patch

@Ardentwheel
Copy link
Owner

Yes, I also think this method is better, thank you😁

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Mar 3, 2021

I think i found the way to fix that HiDPI blinking stuff. First off all thanks to AppleLife forum topic for making and sharing those dumps, also thanks to @khronokernel to managing that "mirror" of database with dumps.

I just copied all of the settings for IGPU from that plist file > now i have no issues with blinking screen using HiDPI

I am not sure if you really need to get all the settings in config, need to figure out which one is actually fixing that problem (maybe a group of them).

There are also device-properties for Thunderbolt, but just copying them didn't help me at all (+ i did inject Apple SSDT for Thunderbolt)

@frozenzero123
Copy link

I think i found the way to fix that HiDPI blinking stuff. First off all thanks to AppleLife forum topic for making and sharing those dumps, also thanks to @khronokernel to managing that "mirror" of database with dumps.

I just copied all of the settings for IGPU from that plist file > now i have no issues with blinking screen using HiDPI

I am not sure if you really need to get all the settings in config, need to figure out which one is actually fixing that problem (maybe a group of them).

There are also device-properties for Thunderbolt, but just copying them didn't help me at all (+ i did inject Apple SSDT for Thunderbolt)

did it worked?and your hidpi is what ?720p?

@m0d16l14n1
Copy link
Collaborator Author

I think i found the way to fix that HiDPI blinking stuff. First off all thanks to AppleLife forum topic for making and sharing those dumps, also thanks to @khronokernel to managing that "mirror" of database with dumps.

I just copied all of the settings for IGPU from that plist file > now i have no issues with blinking screen using HiDPI

I am not sure if you really need to get all the settings in config, need to figure out which one is actually fixing that problem (maybe a group of them).

There are also device-properties for Thunderbolt, but just copying them didn't help me at all (+ i did inject Apple SSDT for Thunderbolt)

did it worked?and your hidpi is what ?720p?

Yes. Any "default" HiDPI resolution is working okay

@Ardentwheel
Copy link
Owner

I think i found the way to fix that HiDPI blinking stuff. First off all thanks to AppleLife forum topic for making and sharing those dumps, also thanks to @khronokernel to managing that "mirror" of database with dumps.

I just copied all of the settings for IGPU from that plist file > now i have no issues with blinking screen using HiDPI

I am not sure if you really need to get all the settings in config, need to figure out which one is actually fixing that problem (maybe a group of them).

There are also device-properties for Thunderbolt, but just copying them didn't help me at all (+ i did inject Apple SSDT for Thunderbolt)

did it worked?and your hidpi is what ?720p?

Yes. Any "default" HiDPI resolution is working okay

+1

@m0d16l14n1
Copy link
Collaborator Author

Seems that you need only add GraphicsDisplaySetup in device-properties to get HiDPI working

@frozenzero123
Copy link

Seems that you need only add GraphicsDisplaySetup in device-properties to get HiDPI working
I found a problem. Hidpi is not a lot of results every time I turn on it. It seems more like a bigsur problem, causing “SLE” to fail to store.

@m0d16l14n1
Copy link
Collaborator Author

Seems that you need only add GraphicsDisplaySetup in device-properties to get HiDPI working
I found a problem. Hidpi is not a lot of results every time I turn on it. It seems more like a bigsur problem, causing “SLE” to fail to store.

Didn't understand what you mean. I have no issues with HiDPI with that device-properties on Big Sur 11.2.2
Can you provide more info about what you mean?

@frozenzero123
Copy link

Seems that you need only add GraphicsDisplaySetup in device-properties to get HiDPI working
I found a problem. Hidpi is not a lot of results every time I turn on it. It seems more like a bigsur problem, causing “SLE” to fail to store.

Didn't understand what you mean. I have no issues with HiDPI with that device-properties on Big Sur 11.2.2
Can you provide more info about what you mean?

sorry!when add a value:“framebuffer-flags”, it works very well

@m0d16l14n1
Copy link
Collaborator Author

@frozenzero123 @Ardentwheel

Tested again. It seems to get HiDPI working you need only AAPL,GfxYTile in device-properties. Other stuff not needed to get it working correctly

@m0d16l14n1
Copy link
Collaborator Author

m0d16l14n1 commented Sep 30, 2021

  • Black screen bug after boot process (glitching/blinking and etc in other Ice Lake laptops) > still unknown how fix that

It's finally fixed (you can read details here)

You can grep test kext here

@m0d16l14n1
Copy link
Collaborator Author

  • Black screen bug after boot process (glitching/blinking and etc in other Ice Lake laptops) > still unknown how fix that

It's finally fixed (you can read details here)

You can grep test kext here

Fix is in master now > acidanthera/WhateverGreen#92

@zkennedy137
Copy link

No, that PR is not related to HDMI on Ice Lake platforms.
The HDMI issue (not DisplayPort-over-Type-C to HDMI) is a complete new story.
Apple has removed HDMI support from the driver. While there are some leftover code related to HDMI in the driver, it is still unknown whether we could port the support back.

got it, okay, wow... thanks for the info, bad news :( will hope for HDMI support than, heh.

Could we not spoof the physical HDMI port to appear as Type-C to HDMI in DSDT somehow?

@m0d16l14n1
Copy link
Collaborator Author

Hibernation is fixed. Still might get black screen, but it's easily to bypass it by closing and opening a lid of laptop after it's booted.

So by now we still have some problems with graphics, they are not so bad, except support of HDMI connection and sound over Type-C to HDMI dongles. But it's really gain more stability with working hibernation now. I will close the "To-do list", as i think it's totally fine to leave it as it is.

I still using that laptop everyday, still debugging and looking to fix more "little" issues and problems. If there any success > i will post more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

10 participants