Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eu.novapost component name #2433

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

nazar-pc
Copy link
Contributor

Apparently not an example anymore 🙈

@Kaiserdragon2
Copy link
Collaborator

instead of changing the component of an existing entries it's good practice to just add it.
So people with an older version still have the icon applied.

@nazar-pc
Copy link
Contributor Author

I can do that, but I'd argue it makes the most sense for applications that can work offline.

This is a frontend to a delivery service though 100% dependent on servers. With application auto-updates being the default (and strongly recommended for security reasons) as well as older versions likely to have issues or not work at all as backend evolves over time, the value of occupying space in the file is very questionable.

Let me know if you still prefer to add instead of update these.

@Kaiserdragon2
Copy link
Collaborator

You are right, but you must also consider a staged rollout. For this one i think it's fine to leave it with the change.

@Donnnno Donnnno merged commit 1f65b8f into Arcticons-Team:main Dec 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants