Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new icons to contribute #2414

Merged
merged 3 commits into from
Dec 21, 2024
Merged

Add new icons to contribute #2414

merged 3 commits into from
Dec 21, 2024

Conversation

hkcowboy
Copy link
Contributor

List of Apps:

  • HKUST QR Code
  • HKUST Student
  • OpenRice
  • Asia Miles
  • Blue Cross HK
  • HKTaxi
  • HKTVmall
  • Keeta
  • MoneyBack
  • MyLink
  • Pizza Hut HK & Macau
  • SoSIM
  • Starbucks HK
  • Yuu

@Donnnno
Copy link
Collaborator

Donnnno commented Dec 21, 2024

Heya @hkcowboy congrats on your first contribution to Arcticons, nice work!

I have a couple of feedback points to keep in mind for your next one :)

  • Check if the line-width of the icons is the same everywhere.
  • The hktaxi icon had a fill-based chinese characters, I've converted those to line-based ones.
  • No need to add copies of existing icons, like with Starbucks or Pizzahut. Instead, just change the appfilter line to the existing icons.

image

My changes:
image

@Donnnno Donnnno merged commit f298eea into Arcticons-Team:main Dec 21, 2024
1 check passed
@hkcowboy
Copy link
Contributor Author

That was quick! Thank you for the inputs - I can't wait for the new release with these icons to be published to f-droid 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants